From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [RFC PATCH 3/3] tcp: Add tunable parameters for TSQ
Date: Fri, 05 Jan 2018 03:53:46 -0800
Message-ID: <1515153226.131759.8.camel@gmail.com>
References: <20180105113256.14835-1-natale.patriciello@gmail.com>
         <20180105113256.14835-4-natale.patriciello@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
To: Natale Patriciello <natale.patriciello@gmail.com>,
        netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf0-f66.google.com ([209.85.215.66]:33784 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751594AbeAELxv (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 5 Jan 2018 06:53:51 -0500
Received: by mail-lf0-f66.google.com with SMTP id j143so4904902lfg.0
        for <netdev@vger.kernel.org>; Fri, 05 Jan 2018 03:53:50 -0800 (PST)
In-Reply-To: <20180105113256.14835-4-natale.patriciello@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 2018-01-05 at 12:32 +0100, Natale Patriciello wrote:
> The original TSQ algorithm limits the number of packets in qdisc/devices to
> two packets / or ~1 ms. With this commit, two sysctl knobs are added to
> allow tuning the number of packets or the ms value.
> 
> Signed-off-by: Natale Patriciello <natale.patriciello@gmail.com>
> Cc: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
> Tested-by: Carlo Augusto Grazia <carloaugusto.grazia@unimore.it>
> ---

NACK

You provide dubious reasons, and no real tests done on various
hardwares.

We do not want sysctls that wont solve the issue you try to address.

Your patch series comes too late.

A linux host can have one 10Gbit NIC and a wifi adapter, they require
different tunings.

This is why we added sk_pacing_shift_update().

If this needs refinement, lets talk.