From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gal Pressman Subject: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro Date: Sun, 7 Jan 2018 12:08:35 +0200 Message-ID: <1515319720-18428-2-git-send-email-galp@mellanox.com> References: <1515319720-18428-1-git-send-email-galp@mellanox.com> Cc: netdev@vger.kernel.org, Tariq Toukan , Saeed Mahameed , Gal Pressman To: "David S. Miller" Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:51860 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752823AbeAGK1C (ORCPT ); Sun, 7 Jan 2018 05:27:02 -0500 In-Reply-To: <1515319720-18428-1-git-send-email-galp@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: netdev_WARN_ONCE is broken (whoops..), this fix will remove the unnecessary "condition" parameter, add the missing comma and change "arg" to "args". Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions") Signed-off-by: Gal Pressman Reviewed-by: Saeed Mahameed --- include/linux/netdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 352066e..5ff1ef9 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4407,8 +4407,8 @@ do { \ WARN(1, "netdevice: %s%s\n" format, netdev_name(dev), \ netdev_reg_state(dev), ##args) -#define netdev_WARN_ONCE(dev, condition, format, arg...) \ - WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev) \ +#define netdev_WARN_ONCE(dev, format, args...) \ + WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev), \ netdev_reg_state(dev), ##args) /* netif printk helpers, similar to netdev_printk */ -- 2.7.4