From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tariq Toukan Subject: [PATCH net-next 0/3] ethtool ringparam upper bound Date: Mon, 8 Jan 2018 16:00:23 +0200 Message-ID: <1515420026-11970-1-git-send-email-tariqt@mellanox.com> Cc: netdev@vger.kernel.org, Eran Ben Elisha , Eugenia Emantayev , Tariq Toukan To: "David S. Miller" Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:42338 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756903AbeAHOBE (ORCPT ); Mon, 8 Jan 2018 09:01:04 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Hi Dave, This patchset by Jenny adds sanity checks in ethtool ringparam operation for input upper bounds, similarly to what's done in ethtool_set_channels. The checks are added in patch 1, using a call to get_ringparam prior to calling set_ringparam NDO. Patch 2 changes the function's behavior in mlx4_en, so that it returns an error for out-of-range input, instead of rounding it to closest valid, similar to mlx5e. Patch 3 removes the upper bound checks in mlx5e_ethtool_set_ringparam as it becomes redundant. Series generated against net-next commit: f66faae2f80a Merge branch 'ipv6-ipv4-nexthop-align' Thanks, Tariq. Eugenia Emantayev (3): ethtool: Ensure new ring parameters are within bounds during SRINGPARAM net/mlx4_en: Align behavior of set ring size flow via ethtool net/mlx5e: Remove redundant checks in set_ringparam drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 17 +++++++++++++---- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 15 --------------- net/core/ethtool.c | 13 +++++++++++-- 3 files changed, 24 insertions(+), 21 deletions(-) -- 1.8.3.1