From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: Larry.Finger@lwfinger.net, kvalo@codeaurora.org,
kstewart@linuxfoundation.org, johannes.berg@intel.com,
tiwai@suse.de, gregkh@linuxfoundation.org,
colin.king@canonical.com, andrew.zaborowski@intel.com
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, b43-dev@lists.infradead.org,
Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post
Date: Tue, 9 Jan 2018 09:40:06 +0800 [thread overview]
Message-ID: <1515462006-6144-1-git-send-email-baijiaju1990@gmail.com> (raw)
b43_radio_2057_init_post is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with usleep_range,
to reduce busy wait.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
v2:
* Replace mdelay with usleep_range, instead of msleep in v1.
Thank Larry for good advice.
---
drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
index a5557d7..f2a2f41 100644
--- a/drivers/net/wireless/broadcom/b43/phy_n.c
+++ b/drivers/net/wireless/broadcom/b43/phy_n.c
@@ -1031,7 +1031,7 @@ static void b43_radio_2057_init_post(struct b43_wldev *dev)
b43_radio_set(dev, R2057_RFPLL_MISC_CAL_RESETN, 0x78);
b43_radio_set(dev, R2057_XTAL_CONFIG2, 0x80);
- mdelay(2);
+ usleep_range(2000, 3000);
b43_radio_mask(dev, R2057_RFPLL_MISC_CAL_RESETN, ~0x78);
b43_radio_mask(dev, R2057_XTAL_CONFIG2, ~0x80);
--
1.7.9.5
next reply other threads:[~2018-01-09 1:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 1:40 Jia-Ju Bai [this message]
2018-01-09 8:35 ` [PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post Greg KH
2018-01-09 8:39 ` Jia-Ju Bai
2018-01-09 9:07 ` Arend van Spriel
2018-01-09 9:47 ` Jia-Ju Bai
2018-01-09 11:11 ` Arend van Spriel
2018-01-09 16:49 ` Larry Finger
[not found] ` <1515462006-6144-1-git-send-email-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-11 19:54 ` [v2] " Kalle Valo
2018-01-11 19:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515462006-6144-1-git-send-email-baijiaju1990@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrew.zaborowski@intel.com \
--cc=b43-dev@lists.infradead.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.berg@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).