From: Joe Perches <joe@perches.com>
To: Gal Pressman <galp@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro
Date: Mon, 08 Jan 2018 18:42:01 -0800 [thread overview]
Message-ID: <1515465721.9619.78.camel@perches.com> (raw)
In-Reply-To: <1515319720-18428-2-git-send-email-galp@mellanox.com>
On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote:
> netdev_WARN_ONCE is broken (whoops..), this fix will remove the
> unnecessary "condition" parameter, add the missing comma and change
> "arg" to "args".
>
> Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions")
> Signed-off-by: Gal Pressman <galp@mellanox.com>
> Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
> ---
> include/linux/netdevice.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 352066e..5ff1ef9 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -4407,8 +4407,8 @@ do { \
> WARN(1, "netdevice: %s%s\n" format, netdev_name(dev), \
> netdev_reg_state(dev), ##args)
>
> -#define netdev_WARN_ONCE(dev, condition, format, arg...) \
> - WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev) \
> +#define netdev_WARN_ONCE(dev, format, args...) \
> + WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev), \
You sure you want the newline before the format?
> netdev_reg_state(dev), ##args)
>
> /* netif printk helpers, similar to netdev_printk */
next prev parent reply other threads:[~2018-01-09 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 10:08 [PATCH net-next v2 0/6] Replace WARN_ONCE usages with netdev_WARN_ONCE Gal Pressman
2018-01-07 10:08 ` [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro Gal Pressman
2018-01-09 2:42 ` Joe Perches [this message]
2018-01-09 3:05 ` David Miller
2018-01-09 9:51 ` Gal Pressman
2018-01-07 10:08 ` [PATCH net-next v2 2/6] net: No line break on netdev_WARN* formatting Gal Pressman
2018-01-07 10:08 ` [PATCH net-next v2 3/6] net/mlx5e: Replace WARN_ONCE with netdev_WARN_ONCE Gal Pressman
2018-01-07 10:08 ` [PATCH net-next v2 4/6] e1000: " Gal Pressman
2018-01-07 10:08 ` [PATCH net-next v2 5/6] bnx2x: " Gal Pressman
2018-01-09 2:40 ` Kalluru, Sudarsana
2018-01-07 10:08 ` [PATCH net-next v2 6/6] 8139cp: " Gal Pressman
2018-01-09 1:53 ` [PATCH net-next v2 0/6] Replace WARN_ONCE usages " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515465721.9619.78.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=galp@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).