From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: [PATCH bpf-next v2 03/14] nfp: bpf: round up the size of the stack Date: Wed, 10 Jan 2018 12:25:56 +0000 Message-ID: <1515587167-1959-4-git-send-email-quentin.monnet@netronome.com> References: <1515587167-1959-1-git-send-email-quentin.monnet@netronome.com> Cc: oss-drivers@netronome.com, jakub.kicinski@netronome.com To: daniel@iogearbox.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:36069 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934432AbeAJM1X (ORCPT ); Wed, 10 Jan 2018 07:27:23 -0500 Received: by mail-wm0-f67.google.com with SMTP id b76so26936910wmg.1 for ; Wed, 10 Jan 2018 04:27:22 -0800 (PST) In-Reply-To: <1515587167-1959-1-git-send-email-quentin.monnet@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Kernel enforces the alignment of the bottom of the stack, NFP deals with positive offsets better so we should align the top of the stack. Round the stack size to NFP word size (4B). Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/offload.c b/drivers/net/ethernet/netronome/nfp/bpf/offload.c index fa2905e67b07..8dbf13450bab 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/offload.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/offload.c @@ -147,7 +147,7 @@ int nfp_bpf_translate(struct nfp_app *app, struct nfp_net *nn, return -EOPNOTSUPP; } - nfp_prog->stack_depth = prog->aux->stack_depth; + nfp_prog->stack_depth = round_up(prog->aux->stack_depth, 4); nfp_prog->start_off = nn_readw(nn, NFP_NET_CFG_BPF_START); nfp_prog->tgt_done = nn_readw(nn, NFP_NET_CFG_BPF_DONE); -- 2.7.4