From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] usbnet: silence an unnecessary warning Date: Thu, 11 Jan 2018 18:09:40 +0100 Message-ID: <1515690580.2992.1.camel@suse.com> References: <20180111150149.32528-1-oneukum@suse.com> <876088wha7.fsf@miraculix.mork.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: =?ISO-8859-1?Q?Bj=F8rn?= Mork Return-path: Received: from mx2.suse.de ([195.135.220.15]:54232 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858AbeAKROb (ORCPT ); Thu, 11 Jan 2018 12:14:31 -0500 In-Reply-To: <876088wha7.fsf@miraculix.mork.no> Sender: netdev-owner@vger.kernel.org List-ID: Am Donnerstag, den 11.01.2018, 16:23 +0100 schrieb Bjørn Mork : > Oliver Neukum writes: > > > > > That a kevent could not be scheduled is not an error. > > Such handlers must be able to deal with multiple events anyway. > > As the successful scheduling of a work is a debug event, make > > the failure debug priority, too. > > > > Signed-off-by: Oliver Neukum > > Reported-by: Cristian Caravena > > --- > > drivers/net/usb/usbnet.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > > index d56fe32bf48d..1e0bbe23f95c 100644 > > --- a/drivers/net/usb/usbnet.c > > +++ b/drivers/net/usb/usbnet.c > > @@ -458,8 +458,7 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) > > { > > set_bit (work, &dev->flags); > > if (!schedule_work (&dev->kevent)) { > > - if (net_ratelimit()) > > - netdev_err(dev->net, "kevent %d may have been dropped\n", work); > > + netdev_dbg(dev->net, "kevent %d may have been dropped\n", work); > > } else { > > netdev_dbg(dev->net, "kevent %d scheduled\n", work); > > } > > Great! But why do you drop the ratelimit? This can be very noisy when > it hits. I'd like to keep it ratelimited. Because this is now a debug output and if you need to debug you may need to verify whether your kevent will be handled. So not getting either of the messages would indicate a bug. Thus limiting the rate would defeat the purpose. Regards Oliver