From mboxrd@z Thu Jan  1 00:00:00 1970
From: yuan linyu <cugyly@163.com>
Subject: Re: [PATCH net-next] net: dpaa: change while() to if() in
 dpaa_fq_setup()
Date: Sat, 13 Jan 2018 17:24:42 +0800
Message-ID: <1515835482.32366.11.camel@163.com>
References: <1515834954-32145-1-git-send-email-cugyly@163.com>
Reply-To: cugyly@163.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: "David S . Miller" <davem@davemloft.net>,
        yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
To: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from m12-13.163.com ([220.181.12.13]:47656 "EHLO m12-13.163.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965373AbeAMJY5 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 13 Jan 2018 04:24:57 -0500
In-Reply-To: <1515834954-32145-1-git-send-email-cugyly@163.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

i am wrong, ignore it.

On 六, 2018-01-13 at 17:15 +0800, yuan linyu wrote:
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> 
> while loop is not needed, because list_for_each_entry() already check all fq.
> 
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 7caa8da..fd0e411 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
>  	}
>  
>  	 /* Make sure all CPUs receive a corresponding Tx queue. */
> -	while (egress_cnt < DPAA_ETH_TXQ_NUM) {
> +	if (egress_cnt < DPAA_ETH_TXQ_NUM) {
>  		list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
>  			if (fq->fq_type != FQ_TYPE_TX)
>  				continue;