* [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup()
@ 2018-01-13 9:15 yuan linyu
2018-01-13 9:24 ` yuan linyu
0 siblings, 1 reply; 3+ messages in thread
From: yuan linyu @ 2018-01-13 9:15 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, yuan linyu
From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
while loop is not needed, because list_for_each_entry() already check all fq.
Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 7caa8da..fd0e411 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
}
/* Make sure all CPUs receive a corresponding Tx queue. */
- while (egress_cnt < DPAA_ETH_TXQ_NUM) {
+ if (egress_cnt < DPAA_ETH_TXQ_NUM) {
list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
if (fq->fq_type != FQ_TYPE_TX)
continue;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup()
2018-01-13 9:15 [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup() yuan linyu
@ 2018-01-13 9:24 ` yuan linyu
2018-01-15 9:32 ` Madalin-cristian Bucur
0 siblings, 1 reply; 3+ messages in thread
From: yuan linyu @ 2018-01-13 9:24 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, yuan linyu
i am wrong, ignore it.
On 六, 2018-01-13 at 17:15 +0800, yuan linyu wrote:
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>
> while loop is not needed, because list_for_each_entry() already check all fq.
>
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 7caa8da..fd0e411 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
> }
>
> /* Make sure all CPUs receive a corresponding Tx queue. */
> - while (egress_cnt < DPAA_ETH_TXQ_NUM) {
> + if (egress_cnt < DPAA_ETH_TXQ_NUM) {
> list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
> if (fq->fq_type != FQ_TYPE_TX)
> continue;
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup()
2018-01-13 9:24 ` yuan linyu
@ 2018-01-15 9:32 ` Madalin-cristian Bucur
0 siblings, 0 replies; 3+ messages in thread
From: Madalin-cristian Bucur @ 2018-01-15 9:32 UTC (permalink / raw)
To: cugyly@163.com, netdev@vger.kernel.org; +Cc: David S . Miller, yuan linyu
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of yuan linyu
> Sent: Saturday, January 13, 2018 11:25 AM
> To: netdev@vger.kernel.org
> Cc: David S . Miller <davem@davemloft.net>; yuan linyu
> <Linyu.Yuan@alcatel-sbell.com.cn>
> Subject: Re: [PATCH net-next] net: dpaa: change while() to if() in
> dpaa_fq_setup()
>
> i am wrong, ignore it.
>
Yes, the wile is required.
Madalin
> On 六, 2018-01-13 at 17:15 +0800, yuan linyu wrote:
> > From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> >
> > while loop is not needed, because list_for_each_entry() already check
> all fq.
> >
> > Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> > ---
> > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > index 7caa8da..fd0e411 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -931,7 +931,7 @@ static void dpaa_fq_setup(struct dpaa_priv *priv,
> > }
> >
> > /* Make sure all CPUs receive a corresponding Tx queue. */
> > - while (egress_cnt < DPAA_ETH_TXQ_NUM) {
> > + if (egress_cnt < DPAA_ETH_TXQ_NUM) {
> > list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
> > if (fq->fq_type != FQ_TYPE_TX)
> > continue;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-15 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-13 9:15 [PATCH net-next] net: dpaa: change while() to if() in dpaa_fq_setup() yuan linyu
2018-01-13 9:24 ` yuan linyu
2018-01-15 9:32 ` Madalin-cristian Bucur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).