From: Johannes Berg <johannes@sipsolutions.net>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: regressions@leemhuis.info, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nl80211: take RCU read lock when calling ieee80211_bss_get_ie()
Date: Sun, 14 Jan 2018 23:40:47 +0100 [thread overview]
Message-ID: <1515969647.26804.33.camel@sipsolutions.net> (raw)
In-Reply-To: <20180114222255.GA9036@light.dominikbrodowski.net>
On Sun, 2018-01-14 at 23:22 +0100, Dominik Brodowski wrote:
>
> + rcu_read_lock();
> ssid_ie = ieee80211_bss_get_ie(&wdev->current_bss->pub,
> WLAN_EID_SSID);
> if (!ssid_ie)
> - break;
nit-picking now: that "break" here may have been easier before these
changes
> + goto nla_rcu_unlock;
> if (nla_put(msg, NL80211_ATTR_SSID, ssid_ie[1], ssid_ie + 2))
> - goto nla_put_failure_locked;
> + goto nla_put_failure_rcu_locked;
> + nla_rcu_unlock:
> + rcu_read_unlock();
> break;
but after, perhaps it's easier to just do
if (ssid_ie &&
nla_put(...)
goto nla_put_failure_rcu_locked;
and avoid the extra label (but yeah, it's getting late)
johannes
next prev parent reply other threads:[~2018-01-14 22:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 7:20 suspicious RCU usage in net/wireless/util.c:778 Dominik Brodowski
2017-12-30 13:11 ` v4.15-rc5 warning: " Dominik Brodowski
2018-01-08 10:04 ` v4.15-rc7 regression/warning: " Dominik Brodowski
2018-01-14 18:03 ` [PATCH] nl80211: take RCU read lock when calling ieee80211_bss_get_ie() Dominik Brodowski
2018-01-14 21:58 ` Johannes Berg
2018-01-14 22:22 ` [PATCH v2] " Dominik Brodowski
2018-01-14 22:40 ` Johannes Berg [this message]
2018-01-15 7:12 ` [PATCH v3] " Dominik Brodowski
2018-01-15 8:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515969647.26804.33.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=netdev@vger.kernel.org \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).