From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used Date: Tue, 16 Jan 2018 09:10:59 -0800 Message-ID: <1516122659.3606.9.camel@gmail.com> References: <1515929577-25914-1-git-send-email-jchapman@katalix.com> <20180116104425.GA1394@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, James Chapman To: Guillaume Nault , Tom Herbert Return-path: Received: from mail-pl0-f43.google.com ([209.85.160.43]:37421 "EHLO mail-pl0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAPRLB (ORCPT ); Tue, 16 Jan 2018 12:11:01 -0500 Received: by mail-pl0-f43.google.com with SMTP id s3so6644375plp.4 for ; Tue, 16 Jan 2018 09:11:01 -0800 (PST) In-Reply-To: <20180116104425.GA1394@alphalink.fr> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2018-01-16 at 11:44 +0100, Guillaume Nault wrote: > > Tom, if I understand KCM correctly, it only makes sense to attach it to > SOCK_STREAM sockets. Shouldn't that be enforced? Maybe we should > restrict it even further, so that only known KCM-safe sockets could be > attached (that is, reject anything that isn't AF_INET* | SOCK_STREAM). I believe I asked the same question months ago. I had no answer. https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/comm it/?id=351050ecd6523374b370341cc29fe61e2201556b Not sure if anyone uses KCM, other than fuzzers ?