* [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static
@ 2018-01-17 3:27 Wei Yongjun
2018-01-17 13:18 ` Arkadi Sharshevsky
2018-01-19 19:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-01-17 3:27 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel, Arkadi Sharshevsky
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning:
symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
index cfacc17..55f9d2d 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
@@ -286,7 +286,7 @@ static void mlxsw_sp_kvdl_parts_fini(struct mlxsw_sp *mlxsw_sp)
mlxsw_sp_kvdl_part_fini(mlxsw_sp, i);
}
-u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
+static u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
{
unsigned int nr_entries;
int bit = -1;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static
2018-01-17 3:27 [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static Wei Yongjun
@ 2018-01-17 13:18 ` Arkadi Sharshevsky
2018-01-19 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Arkadi Sharshevsky @ 2018-01-17 13:18 UTC (permalink / raw)
To: Wei Yongjun, Jiri Pirko, Ido Schimmel; +Cc: netdev, kernel-janitors
On 01/17/2018 05:27 AM, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning:
> symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Arkadi Sharshevsky <arkadis@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> index cfacc17..55f9d2d 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c
> @@ -286,7 +286,7 @@ static void mlxsw_sp_kvdl_parts_fini(struct mlxsw_sp *mlxsw_sp)
> mlxsw_sp_kvdl_part_fini(mlxsw_sp, i);
> }
>
> -u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
> +static u64 mlxsw_sp_kvdl_part_occ(struct mlxsw_sp_kvdl_part *part)
> {
> unsigned int nr_entries;
> int bit = -1;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static
2018-01-17 3:27 [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static Wei Yongjun
2018-01-17 13:18 ` Arkadi Sharshevsky
@ 2018-01-19 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-19 19:52 UTC (permalink / raw)
To: weiyongjun1; +Cc: jiri, idosch, arkadis, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 17 Jan 2018 03:27:33 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning:
> symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-19 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 3:27 [PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static Wei Yongjun
2018-01-17 13:18 ` Arkadi Sharshevsky
2018-01-19 19:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).