From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>,
netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com
Cc: davem@davemloft.net, rds-devel@oss.oracle.com,
santosh.shilimkar@oracle.com
Subject: Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue
Date: Thu, 18 Jan 2018 07:51:03 -0800 [thread overview]
Message-ID: <1516290663.3606.20.camel@gmail.com> (raw)
In-Reply-To: <05d060dc1169649d84c37ad51b0f8fe54a2a3185.1516147540.git.sowmini.varadhan@oracle.com>
On Wed, 2018-01-17 at 04:19 -0800, Sowmini Varadhan wrote:
> Allow the application the ability to use MSG_PEEK with sk_error_queue
> so that it can peek and re-read message in cases where MSG_TRUNC
> may be encountered.
>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Lets not add buggy feature that only fuzzers love to use to trigger
awful bugs.
No serious (performance sensitive) application use MSG_PEEK, because of
extra syscall overhead.
next prev parent reply other threads:[~2018-01-18 15:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 12:19 [PATCH RFC net-next 0/6] rds: zerocopy support Sowmini Varadhan
2018-01-17 12:19 ` [PATCH RFC net-next 1/6] sock: MSG_PEEK support for sk_error_queue Sowmini Varadhan
2018-01-17 23:50 ` Willem de Bruijn
2018-01-18 11:02 ` Sowmini Varadhan
2018-01-18 15:54 ` Eric Dumazet
2018-01-18 16:10 ` Sowmini Varadhan
2018-01-18 16:53 ` Eric Dumazet
2018-01-18 17:12 ` Sowmini Varadhan
2018-01-18 22:54 ` Willem de Bruijn
2018-01-18 23:03 ` Sowmini Varadhan
2018-01-18 23:09 ` Willem de Bruijn
2018-01-18 23:20 ` Sowmini Varadhan
2018-01-18 23:24 ` Willem de Bruijn
2018-01-18 15:51 ` Eric Dumazet [this message]
2018-01-17 12:20 ` [PATCH RFC net-next 2/6] skbuff: export mm_[un]account_pinned_pages for other modules Sowmini Varadhan
2018-01-17 12:20 ` [PATCH RFC net-next 3/6] rds: hold a sock ref from rds_message to the rds_sock Sowmini Varadhan
2018-01-17 12:20 ` [PATCH RFC net-next 4/6] sock: permit SO_ZEROCOPY on PF_RDS socket Sowmini Varadhan
2018-01-18 0:03 ` Willem de Bruijn
2018-01-17 12:20 ` [PATCH RFC net-next 5/6] rds: support for zcopy completion notification Sowmini Varadhan
2018-01-18 0:23 ` Willem de Bruijn
2018-01-18 11:40 ` Sowmini Varadhan
2018-01-18 22:46 ` Willem de Bruijn
2018-01-17 12:20 ` [PATCH RFC net-next 6/6] rds: zerocopy Tx support Sowmini Varadhan
2018-01-18 0:32 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516290663.3606.20.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=sowmini.varadhan@oracle.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).