From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH RFC net-next 1/6] sock: MSG_PEEK support for
 sk_error_queue
Date: Thu, 18 Jan 2018 07:54:47 -0800
Message-ID: <1516290887.3606.21.camel@gmail.com>
References: <cover.1516147540.git.sowmini.varadhan@oracle.com>
         <05d060dc1169649d84c37ad51b0f8fe54a2a3185.1516147540.git.sowmini.varadhan@oracle.com>
         <CAF=yD-KkL+rnSOvYMFKmeaJoD1zLj1mxtroccTNUJGrhm4SyKA@mail.gmail.com>
         <20180118110207.GA24920@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Network Development <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>, rds-devel@oss.oracle.com,
        santosh.shilimkar@oracle.com
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f68.google.com ([74.125.83.68]:46297 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932855AbeARPyu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 18 Jan 2018 10:54:50 -0500
Received: by mail-pg0-f68.google.com with SMTP id s9so12750958pgq.13
        for <netdev@vger.kernel.org>; Thu, 18 Jan 2018 07:54:50 -0800 (PST)
In-Reply-To: <20180118110207.GA24920@oracle.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 2018-01-18 at 06:02 -0500, Sowmini Varadhan wrote:
> On (01/17/18 18:50), Willem de Bruijn wrote:
> > 
> > This can cause reordering with parallel readers. Can we avoid the need
> > for peeking? It also caused a slew of subtle bugs previously.
> 
> Yes, I did notice the potential for re-ordering when writing the patch..
> but these are not actuallly messages from the wire, so is re-ordering 
> fatal?

Some applications out there would break horribly, trust me.