From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used Date: Thu, 18 Jan 2018 11:46:33 -0800 Message-ID: <1516304793.3606.26.camel@gmail.com> References: <20180116.140052.88231511056432866.davem@davemloft.net> <20180117.142538.1972806008716856078.davem@davemloft.net> <20180118151853.GL1422@alphalink.fr> <1516298893.3606.24.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: James Chapman , Guillaume Nault , David Miller , Linux Kernel Network Developers To: Tom Herbert Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:35242 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102AbeARTqf (ORCPT ); Thu, 18 Jan 2018 14:46:35 -0500 Received: by mail-pg0-f67.google.com with SMTP id d6so15154662pgv.2 for ; Thu, 18 Jan 2018 11:46:35 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2018-01-18 at 11:26 -0800, Tom Herbert wrote: > On Thu, Jan 18, 2018 at 10:08 AM, Eric Dumazet wrote: > > On Thu, 2018-01-18 at 09:46 -0800, Tom Herbert wrote: > > > > > > Then that's increasing the udp_sock structure size for a narrow use > > > case which will get push back. I think it's going to be better to > > > stick with one sock pointer. We could maybe redefine sk_user_data as a > > > pointer to an allocated structure or array so it can hold multiple > > > user_data pointers (in lieu of chaining). > > > > > > > We do not have a lot of UDP sockets per host, I do not believe it > > should be a problem adding stuff in them. > > > > Eric, > > Is QUIC using unconnected sockets then? Server side is using a bunch of unconnected sockets, usually one per cpu. Note that UDP stack has no 4-tuple proper support yet, and even if it had, extra memory costs would be huge on servers handling millions of flows.