From: Davide Caratti <dcaratti@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v2 2/2] net/sched: act_csum: don't use spinlock in the fast path
Date: Mon, 22 Jan 2018 12:16:59 +0100 [thread overview]
Message-ID: <1516619819.3495.23.camel@redhat.com> (raw)
In-Reply-To: <CAM_iQpWybQrpEddtdbCgy8u6_b46orzddko2Spy8nxEGtwG4pA@mail.gmail.com>
hello Cong,
On Sun, 2018-01-21 at 12:28 -0800, Cong Wang wrote:
> > + params = rcu_dereference(p->params);
>
> I think you need rtnl_dereference() here, as we don't have RCU read lock here?
you are right, thank you for spotting this.
I will send v3 series today.
regards,
--
davide
prev parent reply other threads:[~2018-01-22 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 14:12 [PATCH net-next v2 0/2] net/sched: remove spinlock from 'csum' action Davide Caratti
2018-01-19 14:12 ` [PATCH net-next v2 1/2] net/sched: act_csum: use per-core statistics Davide Caratti
2018-01-19 14:12 ` [PATCH net-next v2 2/2] net/sched: act_csum: don't use spinlock in the fast path Davide Caratti
2018-01-21 20:28 ` Cong Wang
2018-01-22 11:16 ` Davide Caratti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516619819.3495.23.camel@redhat.com \
--to=dcaratti@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).