From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: [PATCH iproute2-next] gre/gre6: Post merge fixes Date: Mon, 22 Jan 2018 16:50:08 +0200 Message-ID: <1516632608-17513-1-git-send-email-serhe.popovych@gmail.com> To: netdev@vger.kernel.org Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:45396 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbeAVOuS (ORCPT ); Mon, 22 Jan 2018 09:50:18 -0500 Received: by mail-wm0-f68.google.com with SMTP id i186so16806200wmi.4 for ; Mon, 22 Jan 2018 06:50:17 -0800 (PST) Received: from tuxracer.localdomain ([2a01:6d80::195:20:96:53]) by smtp.gmail.com with ESMTPSA id q11sm6911171edj.64.2018.01.22.06.50.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 06:50:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Few minor changes after merge of 'master' into 'net-next' branch: 1) Follow 80 line length for printing erspan_index parameter as we did in master with commit 2a8d0f6e9c3f ("gre/tunnel: Print erspan_index using print_uint()"). 2) Remove remnants of encapsulation option printing: now it is done using tnl_print_encap() helper in commit bad76e6b1f44 ("ip/tunnel: Abstract tunnel encapsulation options printing"). Fixes: 8c75f69411bc ("Merge branch 'master' into net-next") Signed-off-by: Serhey Popovych --- ip/link_gre.c | 3 ++- ip/link_gre6.c | 46 ++-------------------------------------------- 2 files changed, 4 insertions(+), 45 deletions(-) diff --git a/ip/link_gre.c b/ip/link_gre.c index 674603b..a430ab8 100644 --- a/ip/link_gre.c +++ b/ip/link_gre.c @@ -506,7 +506,8 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) if (tb[IFLA_GRE_ERSPAN_INDEX]) { __u32 erspan_idx = rta_getattr_u32(tb[IFLA_GRE_ERSPAN_INDEX]); - print_uint(PRINT_ANY, "erspan_index", "erspan_index %u ", erspan_idx); + print_uint(PRINT_ANY, + "erspan_index", "erspan_index %u ", erspan_idx); } if (tb[IFLA_GRE_ERSPAN_VER]) { diff --git a/ip/link_gre6.c b/ip/link_gre6.c index a0eeb5a..5f465fe 100644 --- a/ip/link_gre6.c +++ b/ip/link_gre6.c @@ -568,7 +568,8 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) if (tb[IFLA_GRE_ERSPAN_INDEX]) { __u32 erspan_idx = rta_getattr_u32(tb[IFLA_GRE_ERSPAN_INDEX]); - print_uint(PRINT_ANY, "erspan_index", "erspan_index %u ", erspan_idx); + print_uint(PRINT_ANY, + "erspan_index", "erspan_index %u ", erspan_idx); } if (tb[IFLA_GRE_ERSPAN_VER]) { @@ -594,49 +595,6 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) print_hex(PRINT_ANY, "erspan_hwid", "erspan_hwid 0x%x ", erspan_hwid); } - if (tb[IFLA_GRE_ENCAP_TYPE] && - rta_getattr_u16(tb[IFLA_GRE_ENCAP_TYPE]) != TUNNEL_ENCAP_NONE) { - __u16 type = rta_getattr_u16(tb[IFLA_GRE_ENCAP_TYPE]); - __u16 flags = rta_getattr_u16(tb[IFLA_GRE_ENCAP_FLAGS]); - __u16 sport = rta_getattr_u16(tb[IFLA_GRE_ENCAP_SPORT]); - __u16 dport = rta_getattr_u16(tb[IFLA_GRE_ENCAP_DPORT]); - - open_json_object("encap"); - - print_string(PRINT_FP, NULL, "encap ", NULL); - switch (type) { - case TUNNEL_ENCAP_FOU: - print_string(PRINT_ANY, "type", "%s ", "fou"); - break; - case TUNNEL_ENCAP_GUE: - print_string(PRINT_ANY, "type", "%s ", "gue"); - break; - default: - print_null(PRINT_ANY, "type", "unknown ", NULL); - break; - } - - if (is_json_context()) { - print_uint(PRINT_JSON, - "sport", - NULL, - sport ? ntohs(sport) : 0); - print_uint(PRINT_JSON, "dport", NULL, ntohs(dport)); - print_bool(PRINT_JSON, "csum", NULL, - flags & TUNNEL_ENCAP_FLAG_CSUM); - print_bool(PRINT_JSON, "csum6", NULL, - flags & TUNNEL_ENCAP_FLAG_CSUM6); - print_bool(PRINT_JSON, "remcsum", NULL, - flags & TUNNEL_ENCAP_FLAG_REMCSUM); - close_json_object(); - } else { - if (sport == 0) - fputs("encap-sport auto ", f); - else - fprintf(f, "encap-sport %u", ntohs(sport)); - } - } - tnl_print_encap(tb, IFLA_GRE_ENCAP_TYPE, IFLA_GRE_ENCAP_FLAGS, -- 1.7.10.4