From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] 8139too: revisit napi_complete_done() usage
Date: Mon, 22 Jan 2018 11:03:48 -0800
Message-ID: <1516647828.3478.11.camel@gmail.com>
References: <20170410121102.GM30290@intel.com>
         <20170918194630.GH4914@intel.com>
         <1505765023.29839.32.camel@edumazet-glaptop3.roam.corp.google.com>
         <20170918.205729.1447641244948185208.davem@davemloft.net>
         <CAP8WD_Y0cfJ_Oe0mjVfR_nAAaz_UF3+=Zk7fjiiJvmfh7PyEtQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: ville.syrjala@linux.intel.com, netdev <netdev@vger.kernel.org>
To: whiteheadm@acm.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f48.google.com ([74.125.83.48]:45844 "EHLO
        mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751125AbeAVTDt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 22 Jan 2018 14:03:49 -0500
Received: by mail-pg0-f48.google.com with SMTP id m136so853016pga.12
        for <netdev@vger.kernel.org>; Mon, 22 Jan 2018 11:03:49 -0800 (PST)
In-Reply-To: <CAP8WD_Y0cfJ_Oe0mjVfR_nAAaz_UF3+=Zk7fjiiJvmfh7PyEtQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 2018-01-22 at 12:27 -0500, tedheadster wrote:
> On Mon, Sep 18, 2017 at 11:57 PM, David Miller <davem@davemloft.net> wrote:
> > From: Eric Dumazet <eric.dumazet@gmail.com>
> > Date: Mon, 18 Sep 2017 13:03:43 -0700
> > 
> > > From: Eric Dumazet <edumazet@google.com>
> > > 
> > > It seems we have to be more careful in napi_complete_done()
> > > use. This patch is not a revert, as it seems we can
> > > avoid bug that Ville reported by moving the napi_complete_done()
> > > test in the spinlock section.
> > > 
> > > Many thanks to Ville for detective work and all tests.
> > > 
> > > Fixes: 617f01211baf ("8139too: use napi_complete_done()")
> > > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Applied and queued up for -stable.
> 
> Eric,
>   sorry to bring up this old thread, but I had a question. Do we have
> to surround most usage of napi_complete_done() with a spinlock, or was
> this problem restricted to just the 8139too driver?


I am not aware of any other NIC driver having a problem there.