From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] [net] softnet_data: Split time_squeeze counter to provide budget_squeeze Date: Tue, 23 Jan 2018 09:07:06 -0800 Message-ID: <1516727226.3715.1.camel@gmail.com> References: <1516721834-7740-1-git-send-email-ptalbert@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: Patrick Talbert , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:38892 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbeAWRHH (ORCPT ); Tue, 23 Jan 2018 12:07:07 -0500 Received: by mail-pg0-f41.google.com with SMTP id y27so702484pgc.5 for ; Tue, 23 Jan 2018 09:07:07 -0800 (PST) In-Reply-To: <1516721834-7740-1-git-send-email-ptalbert@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2018-01-23 at 10:37 -0500, Patrick Talbert wrote: > Add a 'budget_squeeze' counter to be able to differenciate between a > NAPI poll ending with outstanding work because of a lack of budget > (netdev_budget) versus ending because of a lack of time > (netdev_budget_usecs). > > Signed-off-by: Patrick Talbert > --- a/net/core/net-procfs.c > +++ b/net/core/net-procfs.c > @@ -160,11 +160,11 @@ static int softnet_seq_show(struct seq_file *seq, void *v) > #endif > > seq_printf(seq, > - "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n", > + "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n", > sd->processed, sd->dropped, sd->time_squeeze, 0, > 0, 0, 0, 0, /* was fastroute */ > 0, /* was cpu_collision */ > - sd->received_rps, flow_limit_count); > + sd->received_rps, flow_limit_count, sd->budget_squeeze); > return 0; > } Please no more updates on /proc files. We want to deprecate them eventually.