From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2 net-next] net/ipv6: Do not allow route add with a
 device that is down
Date: Wed, 24 Jan 2018 09:23:34 -0800
Message-ID: <1516814614.3715.24.camel@gmail.com>
References: <20180124162924.6984-1-dsahern@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: yoshfuji@linux-ipv6.org, idosch@mellanox.com,
        roopa@cumulusnetworks.com
To: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f193.google.com ([209.85.192.193]:36287 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S964810AbeAXRXh (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 24 Jan 2018 12:23:37 -0500
Received: by mail-pf0-f193.google.com with SMTP id 23so3605927pfp.3
        for <netdev@vger.kernel.org>; Wed, 24 Jan 2018 09:23:37 -0800 (PST)
In-Reply-To: <20180124162924.6984-1-dsahern@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2018-01-24 at 08:29 -0800, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin down.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> v2
> - missed setting err to -ENETDOWN (thanks for catching that Roopa)
> 
>  net/ipv6/route.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index f85da2f1e729..4e8fab766018 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -2734,6 +2734,12 @@ static struct rt6_info *ip6_route_info_create(struct fib6_config *cfg,
>  	if (!dev)
>  		goto out;
>  
> +	err = -ENETDOWN;
> +	if (!(dev->flags & IFF_UP)) {
> +		NL_SET_ERR_MSG(extack, "Nexthop device is not up");
> +		goto out;
> +	}


Note that since you have to take a branch, you can move the 
err = -ENETDOWN inside the branch.

The trick of setting err before doing :

if (cond)
   goto xxxx;

Is only relevant if the goto is naked.

By looking at your patch without more context, it is not clear that the
"err = -ENETDOWN" has no side effect.