From: Serhey Popovych <serhe.popovych@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH iproute2-next v3 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match_rta()
Date: Wed, 24 Jan 2018 20:56:32 +0200 [thread overview]
Message-ID: <1516820200-13723-1-git-send-email-serhe.popovych@gmail.com> (raw)
Now we enhance get_addr() to return additional information about address
(e.g. if it unspecified or multicast) we want to have same functionality
for attributes in netlink message.
Introduce and use get_addr_rta() that parses given netlink attribute
into @inet_prefix data structure in the same way similar get_addr()
parses address from it's string representation.
Use attribute length to guess address family: force it by giving non
AF_UNSPEC @family to get_addr_rta() to ensure address is of expected
family.
Introduce and use inet_addr_match_rta() to further simplify and unify
code where get_addr_rta() intended to be used together with
inet_addr_match().
This is next step in ipv4 and ipv6 modules unification to prepare for
merge in the future.
Any comments, suggestions and criticism as always welcome.
v3
Rebase to current iproute2-next/master. Adjust automatic line wrapping
in editor to 72 max.
v2
Introduce and use inet_addr_match_rta() as suggested by David Ahern.
Check for result from get_prefix() in places where
inet_addr_match_rta() being used.
Thanks,
Serhii
Serhey Popovych (8):
utils: Introduce get_addr_rta() and inet_addr_match_rta()
ipaddress: Use inet_addr_match_rta()
iprule: Use inet_addr_match_rta()
ipmroute: Use inet_addr_match_rta()
ipneigh: Use inet_addr_match_rta()
ipl2tp: Use get_addr_rta()
tcp_metric: Use get_addr_rta()
ip/tunnel: Unify local/remote endpoint address printing
include/utils.h | 2 ++
ip/ipaddress.c | 29 ++++++-----------
ip/ipl2tp.c | 37 +++++++++------------
ip/ipmroute.c | 26 ++++++---------
ip/ipneigh.c | 13 +++-----
ip/iprule.c | 36 ++++++++++-----------
ip/link_gre.c | 21 ++----------
ip/link_gre6.c | 26 ++-------------
ip/link_ip6tnl.c | 15 ++-------
ip/link_iptnl.c | 21 ++----------
ip/link_vti.c | 21 ++----------
ip/link_vti6.c | 21 ++----------
ip/tcp_metrics.c | 60 +++++++++++++++++-----------------
ip/tunnel.c | 27 ++++++++++++++++
ip/tunnel.h | 2 ++
lib/utils.c | 95 +++++++++++++++++++++++++++++++++++++++++++-----------
16 files changed, 206 insertions(+), 246 deletions(-)
--
1.7.10.4
next reply other threads:[~2018-01-24 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 18:56 Serhey Popovych [this message]
2018-01-24 18:56 ` [PATCH iproute2-next v3 1/8] utils: Introduce get_addr_rta() and inet_addr_match_rta() Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 2/8] ipaddress: Use inet_addr_match_rta() Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 3/8] iprule: " Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 4/8] ipmroute: " Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 5/8] ipneigh: " Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 6/8] ipl2tp: Use get_addr_rta() Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 7/8] tcp_metric: " Serhey Popovych
2018-01-24 18:56 ` [PATCH iproute2-next v3 8/8] ip/tunnel: Unify local/remote endpoint address printing Serhey Popovych
2018-01-25 17:34 ` [PATCH iproute2-next v3 0/8] ip: Introduce and use get_addr_rta()/inet_addr_match_rta() David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516820200-13723-1-git-send-email-serhe.popovych@gmail.com \
--to=serhe.popovych@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).