From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2 0/4] Check size of packets before sending Date: Thu, 25 Jan 2018 06:35:04 -0800 Message-ID: <1516890904.3715.50.camel@gmail.com> References: <20180125043109.28332-1-dja@axtens.net> <1516884036.3715.45.camel@gmail.com> <87607qdpdf.fsf@linkitivity.dja.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jason Wang , Pravin Shelar , Marcelo Ricardo Leitner , Manish.Chopra@cavium.com, dev@openvswitch.org To: Daniel Axtens , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:39923 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbeAYOfG (ORCPT ); Thu, 25 Jan 2018 09:35:06 -0500 Received: by mail-pf0-f169.google.com with SMTP id e11so5883282pff.6 for ; Thu, 25 Jan 2018 06:35:06 -0800 (PST) In-Reply-To: <87607qdpdf.fsf@linkitivity.dja.id.au> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote: > Hi Eric, > > > May I ask which tree are you targeting ? > > > > ( Documentation/networking/netdev-FAQ.txt ) > > I have been targeting net-next, but I haven't pulled for about two > weeks. I will rebase and if there are conflicts I will resend early next > week. > > > Anything touching GSO is very risky and should target net-next, > > especially considering 4.15 is released this week end. > > > > Are we really willing to backport this intrusive series in stable > > trees, or do we have a smaller fix for bnx2x ? > > I do actually have a smaller fix for bnx2x, although it would need more work: > https://patchwork.ozlabs.org/patch/859410/ > > It leaves open the possibility of too-large packets causing issues on > other drivers. DaveM wasn't a fan: https://patchwork.ozlabs.org/patch/859410/#1839429 Yes, I know he prefers a generic solution, but I am pragmatic here. Old kernels are very far from current GSO stack in net-next. Backporting all the dependencies is going to be very boring/risky.