From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net v2] dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state Date: Fri, 26 Jan 2018 07:56:18 -0800 Message-ID: <1516982178.3715.59.camel@gmail.com> References: <1516968856-900-1-git-send-email-alexey.kodanev@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , David Miller , dccp@vger.kernel.org To: Alexey Kodanev , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:39731 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbeAZP4U (ORCPT ); Fri, 26 Jan 2018 10:56:20 -0500 In-Reply-To: <1516968856-900-1-git-send-email-alexey.kodanev@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2018-01-26 at 15:14 +0300, Alexey Kodanev wrote: > ccid2_hc_tx_rto_expire() timer callback always restarts the timer > again and can run indefinitely (unless it is stopped outside), and after > commit 120e9dabaf55 ("dccp: defer ccid_hc_tx_delete() at dismantle time"), > which moved ccid_hc_tx_delete() (also includes sk_stop_timer()) from > dccp_destroy_sock() to sk_destruct(), this started to happen quite often. > The timer prevents releasing the socket, as a result, sk_destruct() won't > be called. > > Found with LTP/dccp_ipsec tests running on the bonding device, > which later couldn't be unloaded after the tests were completed: > > unregister_netdevice: waiting for bond0 to become free. Usage count = 148 > > Fixes: 2a91aa396739 ("[DCCP] CCID2: Initial CCID2 (TCP-Like) implementation") > Signed-off-by: Alexey Kodanev > --- Reviewed-by: Eric Dumazet Thanks Alexey.