From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] ipv6: change route cache aging logic
Date: Sat, 27 Jan 2018 10:39:44 +0100
Message-ID: <1517045984.3170.1.camel@redhat.com>
References: <20180126194017.48018-1-tracywwnj@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Eric Dumazet <edumazet@google.com>, Martin KaFai Lau <kafai@fb.com>
To: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
        netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:38200 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752136AbeA0Jjr (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 27 Jan 2018 04:39:47 -0500
In-Reply-To: <20180126194017.48018-1-tracywwnj@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 2018-01-26 at 11:40 -0800, Wei Wang wrote:
> From: Wei Wang <weiwan@google.com>
> 
> In current route cache aging logic, if a route has both RTF_EXPIRE and
> RTF_GATEWAY set, the route will only be removed if the neighbor cache
> has no RTN_ROUTE flag. Otherwise, even if the route has expired, it
> won't get deleted.
> Fix this logic to always check if the route has expired first and then
> do the gateway neighbor cache check if previous check decide to not
> remove the exception entry.
> 
> Fixes: 1859bac04fb6 ("ipv6: remove from fib tree aged out RTF_CACHE dst")
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Thank you for the fix!

LGTM

Acked-by: Paolo Abeni <pabeni@redhat.com>

Cheers,

/P