From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Axtens <dja@axtens.net>, netdev@vger.kernel.org
Cc: Manish.Chopra@cavium.com, Jason Wang <jasowang@redhat.com>,
Pravin Shelar <pshelar@ovn.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH v4 2/2] bnx2x: disable GSO where gso_size is too big for hardware
Date: Wed, 31 Jan 2018 13:43:11 -0800 [thread overview]
Message-ID: <1517434991.3715.103.camel@gmail.com> (raw)
In-Reply-To: <20180131031534.25166-3-dja@axtens.net>
On Wed, 2018-01-31 at 14:15 +1100, Daniel Axtens wrote:
> If a bnx2x card is passed a GSO packet with a gso_size larger than
> ~9700 bytes, it will cause a firmware error that will bring the card
> down:
>
> bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert!
> bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2
> bnx2x: [bnx2x_mc_assert:736(enP24p1s0f0)]XSTORM_ASSERT_INDEX 0x0 = 0x00000000 0x25e43e47 0x00463e01 0x00010052
> bnx2x: [bnx2x_mc_assert:750(enP24p1s0f0)]Chip Revision: everest3, FW Version: 7_13_1
> ... (dump of values continues) ...
>
> Detect when the mac length of a GSO packet is greater than the maximum
> packet size (9700 bytes) and disable GSO.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
>
> ---
>
> v4: Only call the slow check if the gso_size is large.
> Eric - I think this is what you had in mind?
> Manish - do you think this is an acceptable performance trade-off?
> GSO will work for any packet size, and only jumbo frames will
> have to do the slower test.
Yes this looks good to me, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2018-01-31 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 3:15 [PATCH v4 0/2] bnx2x: disable GSO on too-large packets Daniel Axtens
2018-01-31 3:15 ` [PATCH v4 1/2] net: create skb_gso_validate_mac_len() Daniel Axtens
2018-01-31 3:15 ` [PATCH v4 2/2] bnx2x: disable GSO where gso_size is too big for hardware Daniel Axtens
2018-01-31 9:00 ` Chopra, Manish
2018-01-31 21:11 ` Daniel Axtens
2018-01-31 21:43 ` Eric Dumazet [this message]
2018-02-01 14:36 ` [PATCH v4 0/2] bnx2x: disable GSO on too-large packets David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517434991.3715.103.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Manish.Chopra@cavium.com \
--cc=dja@axtens.net \
--cc=jasowang@redhat.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).