From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v4 2/2] bnx2x: disable GSO where gso_size is too big for hardware Date: Wed, 31 Jan 2018 13:43:11 -0800 Message-ID: <1517434991.3715.103.camel@gmail.com> References: <20180131031534.25166-1-dja@axtens.net> <20180131031534.25166-3-dja@axtens.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Manish.Chopra@cavium.com, Jason Wang , Pravin Shelar , Marcelo Ricardo Leitner To: Daniel Axtens , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:40340 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbeAaVnN (ORCPT ); Wed, 31 Jan 2018 16:43:13 -0500 Received: by mail-pg0-f41.google.com with SMTP id g16so11145905pgn.7 for ; Wed, 31 Jan 2018 13:43:13 -0800 (PST) In-Reply-To: <20180131031534.25166-3-dja@axtens.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2018-01-31 at 14:15 +1100, Daniel Axtens wrote: > If a bnx2x card is passed a GSO packet with a gso_size larger than > ~9700 bytes, it will cause a firmware error that will bring the card > down: > > bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! > bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 > bnx2x: [bnx2x_mc_assert:736(enP24p1s0f0)]XSTORM_ASSERT_INDEX 0x0 = 0x00000000 0x25e43e47 0x00463e01 0x00010052 > bnx2x: [bnx2x_mc_assert:750(enP24p1s0f0)]Chip Revision: everest3, FW Version: 7_13_1 > ... (dump of values continues) ... > > Detect when the mac length of a GSO packet is greater than the maximum > packet size (9700 bytes) and disable GSO. > > Signed-off-by: Daniel Axtens > > --- > > v4: Only call the slow check if the gso_size is large. > Eric - I think this is what you had in mind? > Manish - do you think this is an acceptable performance trade-off? > GSO will work for any packet size, and only jumbo frames will > have to do the slower test. Yes this looks good to me, thanks ! Reviewed-by: Eric Dumazet