From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roman Gushchin <guro@fb.com>
Cc: Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, "David S . Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()"
Date: Fri, 02 Feb 2018 10:39:04 -0800 [thread overview]
Message-ID: <1517596744.3715.137.camel@gmail.com> (raw)
In-Reply-To: <20180202180624.GA11596@castle.DHCP.thefacebook.com>
On Fri, 2018-02-02 at 18:06 +0000, Roman Gushchin wrote:
>
> Idk, how even we can hit it? And if so, what scary will happen?
>
> If you prefer to have it there, I definitely can return it,
> but I see no profit so far.
I was simply curious this was not mentioned in the changelog.
A revert is normally a true revert, modulo the changes needed by
conflicts and possible changes.
I personally do not care of this BUG_ON(), I had not put it in the
first place.
Thanks.
next prev parent reply other threads:[~2018-02-02 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 16:57 [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()" Roman Gushchin
2018-02-02 17:59 ` Eric Dumazet
2018-02-02 18:06 ` Roman Gushchin
2018-02-02 18:39 ` Eric Dumazet [this message]
2018-02-02 19:04 ` Roman Gushchin
2018-02-02 19:34 ` Eric Dumazet
2018-02-02 19:54 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517596744.3715.137.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).