From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()" Date: Fri, 02 Feb 2018 10:39:04 -0800 Message-ID: <1517596744.3715.137.camel@gmail.com> References: <20180202165754.8551-1-guro@fb.com> <1517594367.3715.130.camel@gmail.com> <20180202180624.GA11596@castle.DHCP.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, "David S . Miller" , Johannes Weiner , Tejun Heo To: Roman Gushchin Return-path: Received: from mail-pl0-f52.google.com ([209.85.160.52]:43921 "EHLO mail-pl0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbeBBSjI (ORCPT ); Fri, 2 Feb 2018 13:39:08 -0500 In-Reply-To: <20180202180624.GA11596@castle.DHCP.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2018-02-02 at 18:06 +0000, Roman Gushchin wrote: > > Idk, how even we can hit it? And if so, what scary will happen? > > If you prefer to have it there, I definitely can return it, > but I see no profit so far. I was simply curious this was not mentioned in the changelog. A revert is normally a true revert, modulo the changes needed by conflicts and possible changes. I personally do not care of this BUG_ON(), I had not put it in the first place. Thanks.