From: Andrew Lunn <andrew@lunn.ch>
To: netdev <netdev@vger.kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
sean.wang@mediatek.com, Woojung.Huh@microchip.com,
john@phrozen.org, jbe@pengutronix.de, richardcochran@gmail.com,
Andrew Lunn <andrew@lunn.ch>
Subject: [RFC PATCH 11/12] net: dsa: mv88e6xxx: Release mutex between each statistics read
Date: Sat, 3 Feb 2018 22:40:15 +0100 [thread overview]
Message-ID: <1517694016-6692-12-git-send-email-andrew@lunn.ch> (raw)
In-Reply-To: <1517694016-6692-1-git-send-email-andrew@lunn.ch>
The PTP code needs low latency access to the PTP hardware timestamps.
Reading all the statistics in one go adds a lot of latency to the PTP
code. So take and release the reg_lock mutex for each individual
statistics, allowing the PTP thread jump in between.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index af63710e93c1..bd5cb8a0330e 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -714,9 +714,12 @@ static void mv88e6xxx_stats_get_stats(struct mv88e6xxx_chip *chip, int port,
for (i = 0, j = 0; i < ARRAY_SIZE(mv88e6xxx_hw_stats); i++) {
stat = &mv88e6xxx_hw_stats[i];
if (stat->type & types) {
+ mutex_lock(&chip->reg_lock);
data[j] = _mv88e6xxx_get_ethtool_stat(chip, stat, port,
bank1_select,
histogram);
+ mutex_unlock(&chip->reg_lock);
+
j++;
}
}
@@ -764,14 +767,13 @@ static void mv88e6xxx_get_ethtool_stats(struct dsa_switch *ds, int port,
mutex_lock(&chip->reg_lock);
ret = mv88e6xxx_stats_snapshot(chip, port);
- if (ret < 0) {
- mutex_unlock(&chip->reg_lock);
+ mutex_unlock(&chip->reg_lock);
+
+ if (ret < 0)
return;
- }
mv88e6xxx_get_stats(chip, port, data);
- mutex_unlock(&chip->reg_lock);
}
static int mv88e6xxx_stats_set_histogram(struct mv88e6xxx_chip *chip)
--
2.15.1
next prev parent reply other threads:[~2018-02-03 21:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 21:40 [RFC PATCH 00/10] PTP support for DSA and mv88e6xxx driver Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 01/10] net: ptp: Add stub for ptp_classify_raw() Andrew Lunn
2018-02-04 9:34 ` Sergei Shtylyov
2018-02-03 21:40 ` [RFC PATCH 02/10] net: dsa: mv88e6xxx: export g2 register accessors Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 03/10] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 04/10] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock Andrew Lunn
2018-02-09 20:33 ` Richard Cochran
2018-02-09 21:04 ` Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 05/10] net: dsa: mv88e6xxx: add support for GPIO configuration Andrew Lunn
2018-02-04 19:53 ` Florian Fainelli
2018-02-04 20:17 ` Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 06/10] net: dsa: mv88e6xxx: add support for event capture Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 07/10] net: dsa: forward hardware timestamping ioctls to switch driver Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 08/10] net: dsa: forward timestamping callbacks to switch drivers Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 09/10] net: dsa: mv88e6xxx: add rx/tx timestamping support Andrew Lunn
2018-02-03 21:40 ` [RFC PATCH 10/10] net: dsa: mv88e6xxx: add workaround for 6341 timestamping Andrew Lunn
2018-02-03 21:40 ` Andrew Lunn [this message]
2018-02-03 21:40 ` [RFC PATCH 12/12] net: dsa: mv88e6xxx: Release mutex between each ATU read Andrew Lunn
2018-02-06 19:44 ` [RFC PATCH 00/10] PTP support for DSA and mv88e6xxx driver Brandon Streiff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517694016-6692-12-git-send-email-andrew@lunn.ch \
--to=andrew@lunn.ch \
--cc=Woojung.Huh@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=jbe@pengutronix.de \
--cc=john@phrozen.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).