From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: Re: [Android][Kernel][TCP/IP] report of packet discarding
 during tcp handshaking
Date: Wed, 07 Feb 2018 06:44:00 -0800
Message-ID: <1518014640.3715.157.camel@gmail.com>
References: <1517977874.3715.153.camel@gmail.com>
         <20180207021647epcms1p128701b4f7e63a88838dd132221119571@epcms1p1>
         <CGME20180207021647epcms1p128701b4f7e63a88838dd132221119571@epcms1p8>
         <20180207071910epcms1p85cb5bac008d8447c973352e0f7a47253@epcms1p8>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Cc: =?UTF-8?Q?=EC=9C=A0=EA=B8=88=ED=99=98?= <geumhwan.yu@samsung.com>,
        =?UTF-8?Q?=EC=95=88=EC=B9=98=ED=9B=88?= <ch.ahn@samsung.com>
To: soukjin.bae@samsung.com,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f170.google.com ([209.85.223.170]:33953 "EHLO
        mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754011AbeBGOoE (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 7 Feb 2018 09:44:04 -0500
Received: by mail-io0-f170.google.com with SMTP id c17so2247516iod.1
        for <netdev@vger.kernel.org>; Wed, 07 Feb 2018 06:44:03 -0800 (PST)
In-Reply-To: <20180207071910epcms1p85cb5bac008d8447c973352e0f7a47253@epcms1p8>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2018-02-07 at 16:19 +0900, 배석진 wrote:
> Dear Dumazet,
> 
> 
> although with your changes, the problem still there.
> own_req couldn't update the lost_race as you wanted.
> maybee it needs additional locking method.
> 

We are not going to add udelay(500) in a loop to solve a race, sorry.

My patch should work, because the lost_race is true means that the
other cpu had put its new (full blown) socket into the hash table.

So this cpu should find it while doing its second lookup.

If not, too bad. Maybe socket has already been accept() and close()