From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: [PATCH iproute2-next v3 0/4] ip/tunnel: Unify local/remote endpoint address parsing Date: Mon, 12 Feb 2018 22:17:55 +0200 Message-ID: <1518466679-3605-1-git-send-email-serhe.popovych@gmail.com> To: netdev@vger.kernel.org Return-path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:40762 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbeBLUSH (ORCPT ); Mon, 12 Feb 2018 15:18:07 -0500 Received: by mail-lf0-f67.google.com with SMTP id 37so3241176lfs.7 for ; Mon, 12 Feb 2018 12:18:06 -0800 (PST) Received: from tuxracer.localdomain ([2a01:6d80::195:20:96:53]) by smtp.gmail.com with ESMTPSA id f199sm230269lfg.44.2018.02.12.12.18.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 12:18:04 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: Use get_addr_rta() helper to unify address retriveal from netlink message when configuring tunnel and get_addr() to parse endpoint address into @inet_prefix. This is next step towards ip and ipv6 tunnel module merge: endpoint address parsing code will differ only in @family constant being passed to get_addr_rta() and get_addr(). Reviews, comments and suggestions are welcome. v3 Rename inet_prefix_reset_flags() to inet_prefix_reset() looks more convenient to hide reset implementation. v2 Introduce and use inet_prefix_reset_flags() inline helper to initialize @inet_prefix data structure and make code self exmplaining. Set bitlen to zero in link_iptnl.c when kernel does not send corresponding prefixlen and we configure existing tunnel. Thanks, Serhey Serhey Popovych (4): utils: Introduce and use inet_prefix_reset() vti/vti6: Unify local/remote endpoint address parsing gre/gre6: Unify local/remote endpoint address parsing iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing include/utils.h | 5 +++ ip/iplink_geneve.c | 2 +- ip/iplink_vxlan.c | 7 ++-- ip/link_gre.c | 57 +++++++++++++++++------------ ip/link_gre6.c | 38 ++++++++++--------- ip/link_ip6tnl.c | 40 +++++++++++--------- ip/link_iptnl.c | 103 ++++++++++++++++++++++++++-------------------------- ip/link_vti.c | 32 ++++++++++------ ip/link_vti6.c | 38 ++++++++++--------- 9 files changed, 177 insertions(+), 145 deletions(-) -- 1.7.10.4