From mboxrd@z Thu Jan  1 00:00:00 1970
From: Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next 7/8] net: sched: act: handle extack in
 tcf_generic_walker
Date: Tue, 13 Feb 2018 10:58:01 +0100
Message-ID: <1518515881.2858.5.camel@redhat.com>
References: <20180212201911.18704-1-aring@mojatatu.com>
         <20180212201911.18704-8-aring@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
To: Alexander Aring <aring@mojatatu.com>, davem@davemloft.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40618 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S934782AbeBMJ6E (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 13 Feb 2018 04:58:04 -0500
In-Reply-To: <20180212201911.18704-8-aring@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 2018-02-12 at 15:19 -0500, Alexander Aring wrote:
>  
> @@ -211,7 +212,8 @@ int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
>  	} else if (type == RTM_GETACTION) {
>  		return tcf_dump_walker(idrinfo, skb, cb);
>  	} else {
> -		WARN(1, "tcf_generic_walker: unknown action %d\n", type);
> +		WARN(1, "tcf_generic_walker: unknown command %d\n", type);
> +		NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command\n");

minor nit: maybe we don't need the '\n' in the above message? 

thanks!
-- 
davide