From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Abeni Subject: Re: [PATCH net] netfilter: nat: cope with negative port range Date: Tue, 13 Feb 2018 18:22:35 +0100 Message-ID: <1518542555.2376.6.camel@redhat.com> References: <9f25396653751c2d8130d7a1cbb62ae90969f37f.1518533214.git.pabeni@redhat.com> <20180213170217.GA2810@breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Pablo Neira Ayuso , "David S. Miller" , netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com To: Florian Westphal Return-path: In-Reply-To: <20180213170217.GA2810@breakpoint.cc> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2018-02-13 at 18:02 +0100, Florian Westphal wrote: > Paolo Abeni wrote: > > Fixes: c7232c9979cb ("netfilter: add protocol independent NAT core") > > are you sure? > When I looked this was a day 0 bug, the code was just moved from ipv4. You are right, the named commit just move around the bugged code, the bug is apparently there since: commit 5b1158e909ecbe1a052203e0d8df15633f829930 Author: Jozsef Kadlecsik Date: Sat Dec 2 22:07:13 2006 -0800 [NETFILTER]: Add NAT support for nf_conntrack I'll send a v2 with an updated commit message, thanks! Paolo