From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Subject: [PATCH net 2/4] ibmvnic: Fix NAPI structures memory leak
Date: Tue, 13 Feb 2018 18:23:41 -0600 [thread overview]
Message-ID: <1518567823-7138-3-git-send-email-tlfalcon@linux.vnet.ibm.com> (raw)
In-Reply-To: <1518567823-7138-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
This memory is allocated during initialization but never freed,
so do that now.
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 8625f5e..23e0b42 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -825,6 +825,8 @@ static void release_resources(struct ibmvnic_adapter *adapter)
}
}
}
+ kfree(adapter->napi);
+ adapter->napi = NULL;
release_login_rsp_buffer(adapter);
}
--
2.7.5
next prev parent reply other threads:[~2018-02-14 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 0:23 [PATCH net 0/4] ibmvnic: Fix memory leaks in the driver Thomas Falcon
2018-02-14 0:23 ` [PATCH net 1/4] ibmvnic: Fix login buffer memory leaks Thomas Falcon
2018-02-14 0:23 ` Thomas Falcon [this message]
2018-02-14 0:23 ` [PATCH net 3/4] ibmvnic: Free RX socket buffer in case of adapter error Thomas Falcon
2018-02-14 0:23 ` [PATCH net 4/4] ibmvnic: Clean RX pool buffers during device close Thomas Falcon
2018-02-14 19:39 ` [PATCH net 0/4] ibmvnic: Fix memory leaks in the driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518567823-7138-3-git-send-email-tlfalcon@linux.vnet.ibm.com \
--to=tlfalcon@linux.vnet.ibm.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).