From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, tom@quantonium.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] kcm: Call strp_stop before strp_done in kcm_attach
Date: Wed, 14 Feb 2018 14:41:08 -0800 [thread overview]
Message-ID: <1518648068.3715.203.camel@gmail.com> (raw)
In-Reply-To: <20180214.153855.944353206422746864.davem@davemloft.net>
On Wed, 2018-02-14 at 15:38 -0500, David Miller wrote:
> From: Tom Herbert <tom@quantonium.net>
> Date: Wed, 14 Feb 2018 09:22:42 -0800
>
> > In kcm_attach strp_done is called when sk_user_data is already
> > set to fail the attach. strp_done needs the strp to be stopped and
> > warns if it isn't. Call strp_stop in this case to eliminate the
> > warning message.
> >
> > Reported-by: syzbot+88dfb55e4c8b770d86e3@syzkaller.appspotmail.com
> > Fixes: e5571240236c5652f ("kcm: Check if sk_user_data already set in kcm_attach"
> > Signed-off-by: Tom Herbert <tom@quantonium.net>
>
> Applied, thanks Tom.
If bug was add added in e5571240236c5652f then this patch should have
targeted net tree.
prev parent reply other threads:[~2018-02-14 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 17:22 [PATCH net-next] kcm: Call strp_stop before strp_done in kcm_attach Tom Herbert
2018-02-14 20:38 ` David Miller
2018-02-14 22:41 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518648068.3715.203.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).