From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] kcm: Call strp_stop before strp_done in kcm_attach Date: Wed, 14 Feb 2018 14:41:08 -0800 Message-ID: <1518648068.3715.203.camel@gmail.com> References: <20180214172242.3896-1-tom@quantonium.net> <20180214.153855.944353206422746864.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller , tom@quantonium.net Return-path: Received: from mail-pg0-f44.google.com ([74.125.83.44]:42921 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031527AbeBNWlL (ORCPT ); Wed, 14 Feb 2018 17:41:11 -0500 Received: by mail-pg0-f44.google.com with SMTP id y8so2707091pgr.9 for ; Wed, 14 Feb 2018 14:41:11 -0800 (PST) In-Reply-To: <20180214.153855.944353206422746864.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2018-02-14 at 15:38 -0500, David Miller wrote: > From: Tom Herbert > Date: Wed, 14 Feb 2018 09:22:42 -0800 > > > In kcm_attach strp_done is called when sk_user_data is already > > set to fail the attach. strp_done needs the strp to be stopped and > > warns if it isn't. Call strp_stop in this case to eliminate the > > warning message. > > > > Reported-by: syzbot+88dfb55e4c8b770d86e3@syzkaller.appspotmail.com > > Fixes: e5571240236c5652f ("kcm: Check if sk_user_data already set in kcm_attach" > > Signed-off-by: Tom Herbert > > Applied, thanks Tom. If bug was add added in e5571240236c5652f then this patch should have targeted net tree.