* [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
@ 2018-02-15 17:44 Gustavo A. R. Silva
2018-02-15 17:56 ` Ramamurthy, Harshitha
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-02-15 17:44 UTC (permalink / raw)
To: Harshitha Ramamurthy, Jeff Kirsher
Cc: intel-wired-lan, netdev, linux-kernel, Gustavo A. R. Silva
It seems this is a copy-paste error and that the proper variable to use
in this particular case is _src_ instead of _dst_.
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 4955ce3..58be99e 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct i40evf_adapter *adapter,
if (key->src) {
filter->f.mask.tcp_spec.src_port |= cpu_to_be16(0xffff);
- filter->f.data.tcp_spec.src_port = key->dst;
+ filter->f.data.tcp_spec.src_port = key->src;
}
}
filter->f.field_flags = field_flags;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
2018-02-15 17:44 [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower Gustavo A. R. Silva
@ 2018-02-15 17:56 ` Ramamurthy, Harshitha
2018-02-15 18:11 ` Jeff Kirsher
0 siblings, 1 reply; 4+ messages in thread
From: Ramamurthy, Harshitha @ 2018-02-15 17:56 UTC (permalink / raw)
To: Kirsher, Jeffrey T, garsilva@embeddedor.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> It seems this is a copy-paste error and that the proper variable to
> use
> in this particular case is _src_ instead of _dst_.
>
> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Thanks for the patch!
Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
> ---
> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index 4955ce3..58be99e 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct
> i40evf_adapter *adapter,
>
> if (key->src) {
> filter->f.mask.tcp_spec.src_port |=
> cpu_to_be16(0xffff);
> - filter->f.data.tcp_spec.src_port = key->dst;
> + filter->f.data.tcp_spec.src_port = key->src;
> }
> }
> filter->f.field_flags = field_flags;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
2018-02-15 17:56 ` Ramamurthy, Harshitha
@ 2018-02-15 18:11 ` Jeff Kirsher
2018-02-15 18:38 ` Gustavo A. R. Silva
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Kirsher @ 2018-02-15 18:11 UTC (permalink / raw)
To: Ramamurthy, Harshitha, garsilva@embeddedor.com, David Miller
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> > It seems this is a copy-paste error and that the proper variable to
> > use
> > in this particular case is _src_ instead of _dst_.
> >
> > Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Thanks for the patch!
>
> Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Dave, no need for me to pick this patch up and then push to you. You
can circumvent me and pick this up.
> > ---
> > drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
2018-02-15 18:11 ` Jeff Kirsher
@ 2018-02-15 18:38 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-02-15 18:38 UTC (permalink / raw)
To: jeffrey.t.kirsher, Ramamurthy, Harshitha, David Miller
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org
On 02/15/2018 12:11 PM, Jeff Kirsher wrote:
> On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
>> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
>>> It seems this is a copy-paste error and that the proper variable to
>>> use
>>> in this particular case is _src_ instead of _dst_.
>>>
>>> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
>>> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>
>> Thanks for the patch!
>>
Glad to help. :)
>> Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> Dave, no need for me to pick this patch up and then push to you. You
> can circumvent me and pick this up.
>
>>> ---
>>> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks guys.
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-15 18:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 17:44 [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower Gustavo A. R. Silva
2018-02-15 17:56 ` Ramamurthy, Harshitha
2018-02-15 18:11 ` Jeff Kirsher
2018-02-15 18:38 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).