From: Oliver Neukum <oneukum@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Ming Lei <ming.lei@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
jkosina@suse.com
Subject: Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers
Date: Mon, 15 Oct 2012 12:04 +0200 [thread overview]
Message-ID: <15188898.QK0YCDZ0MW@linux-lqwf.site> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1210121126330.1605-100000@iolanthe.rowland.org>
On Friday 12 October 2012 11:29:49 Alan Stern wrote:
> On Fri, 12 Oct 2012, Oliver Neukum wrote:
> > First we have workqueues. bas-gigaset is a good example.
> > The driver kills a scheduled work in pre_reset(). If this is done synchronously
> > the driver may need to wait for a memory allocation inside the work.
> > In principle we could provide a workqueue limited to GFP_NOIO. Is that worth
> > it, or do we just check?
>
> The work routine could set the GFP mask upon entry and exit. Then a
> separate workqueue wouldn't be needed.
Well, yes. But if we have to touch the code we might just as well use GFP-NOIO
> > I am afraid there is no generic solution in the last two cases. What do you think?
>
> The other contexts must also set the GFP mask. Unfortunately, this has
> to be done case-by-case.
This raises a question. If we do the port-power-off stuff, does reset_resume() of every
device under the depowered port have to be called? If so, we cannot exclude vendor
specific drivers from the audit, can we?
Regards
Oliver
next prev parent reply other threads:[~2012-10-15 10:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 6:51 [PATCH 00/12] usbnet: usb_control_msg cleanup Ming Lei
2012-10-02 6:51 ` [PATCH 03/12] usbnet: cdc-ncm: apply introduced usb command APIs Ming Lei
2012-10-02 6:51 ` [PATCH 04/12] usbnet: dm9601: " Ming Lei
2012-10-02 6:51 ` [PATCH 05/12] usbnet: int51x1: " Ming Lei
2012-10-02 6:51 ` [PATCH 06/12] usbnet: mcs7830: " Ming Lei
2012-10-02 6:51 ` [PATCH 09/12] usbnet: sierra_net: " Ming Lei
2012-10-02 6:51 ` [PATCH 10/12] usbnet: smsc75xx: " Ming Lei
[not found] ` <1349160684-6627-1-git-send-email-ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2012-10-02 6:51 ` [PATCH 01/12] usbnet: introduce usbnet 3 command helpers Ming Lei
2012-10-09 8:47 ` Oliver Neukum
2012-10-10 3:19 ` Ming Lei
[not found] ` <CACVXFVOPc0gG3UdWqJ0E+6wiwdPv5EoEgbJ0cvJ4oD4602Yp3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 5:51 ` Oliver Neukum
[not found] ` <4085386.s0fOKMaRDP-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10 8:17 ` Ming Lei
[not found] ` <CACVXFVM7wPLXy0JL7QDnCaZFidwucTFf3t_38DuwukxWtOESHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 8:39 ` Oliver Neukum
[not found] ` <1631246.gHVDWoZpLi-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10 9:48 ` Ming Lei
2012-10-10 10:08 ` Oliver Neukum
2012-10-10 11:02 ` Ming Lei
[not found] ` <CACVXFVPDg89y7LyKLA0YUN7oA2rGfptfHLZhJrqBjTVPjsGdNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 11:25 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B702F-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2012-10-10 11:39 ` Oliver Neukum
2012-10-10 11:45 ` Ming Lei
2012-10-11 3:18 ` Ming Lei
[not found] ` <CACVXFVMynoPm6_wYj2MD-5SvMpB7e1Wk94=XMp588rD8hU=eew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-11 4:11 ` Oliver Neukum
2012-10-11 8:14 ` Ming Lei
[not found] ` <CACVXFVPjx+053r_-QB=8kPCDmk3va3feN9MYdLgpf=eRWGe05A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-11 9:05 ` Oliver Neukum
[not found] ` <1940520.W6hRn23j86-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-11 11:29 ` Ming Lei
[not found] ` <1588459.VLxBbnNMlP-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-11 14:36 ` Alan Stern
2012-10-12 1:43 ` Ming Lei
[not found] ` <CACVXFVPdOkvKBBrshnmQv5cYVdDhi8j0V_WxNwBU9VuDsCLkXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-12 15:18 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210111030570.1170-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-12 13:51 ` Oliver Neukum
2012-10-12 15:17 ` Ming Lei
[not found] ` <CACVXFVOChR3ZJSyjo44AMwzzjx5URWvEe25KY2eV5evJpF9D+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-12 15:33 ` Ming Lei
[not found] ` <3535515.7NRjKhCcrL-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-12 15:29 ` Alan Stern
2012-10-15 10:04 ` Oliver Neukum [this message]
[not found] ` <15188898.QK0YCDZ0MW-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-15 14:27 ` Alan Stern
2012-10-10 5:56 ` Ming Lei
[not found] ` <CACVXFVM7CrxXPYzr+dfWhbbmbF+3sXq4C1q2OauvP6x_jebbYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 8:24 ` Oliver Neukum
2012-10-02 6:51 ` [PATCH 02/12] usbnet: asix: apply introduced usb command APIs Ming Lei
2012-10-02 6:51 ` [PATCH 07/12] usbnet: net1080: " Ming Lei
2012-10-02 6:51 ` [PATCH 08/12] usbnet: plusb: " Ming Lei
2012-10-02 6:51 ` [PATCH 11/12] usbnet: smsc95xx: " Ming Lei
2012-10-09 8:42 ` [PATCH 00/12] usbnet: usb_control_msg cleanup Oliver Neukum
2012-10-02 6:51 ` [PATCH 12/12] usbnet: make device out of suspend before calling usbnet_read/write_cmd Ming Lei
2012-10-09 8:50 ` Oliver Neukum
[not found] ` <2913414.gCAxlQ38lG-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-10-10 2:33 ` Ming Lei
[not found] ` <CACVXFVNb-APsJG=ejW+2jqxTfAFsGhHovpgpsyvk6wUoKn5TzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-10 5:34 ` Oliver Neukum
2012-10-10 6:00 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15188898.QK0YCDZ0MW@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.com \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).