From: Eric Dumazet <eric.dumazet@gmail.com>
To: Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
"David S. Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Jerry Chu <hkchu@google.com>, Dave Taht <dave.taht@gmail.com>
Subject: Re: TCP and BBR: reproducibly low cwnd and bandwidth
Date: Sun, 18 Feb 2018 14:24:09 -0800 [thread overview]
Message-ID: <1518992649.55655.19.camel@gmail.com> (raw)
In-Reply-To: <2562547.S27nl9fb2E@natalenko.name>
On Sun, 2018-02-18 at 22:49 +0100, Oleksandr Natalenko wrote:
> Hi.
>
> On neděle 18. února 2018 22:04:27 CET Eric Dumazet wrote:
> > I was able to take a look today, and I believe this is the time to
> > switch TCP to GSO being always on.
> >
> > As a bonus, we get speed boost for cubic as well.
> >
> > Todays high BDP and recent TCP improvements (rtx queue as rb-tree, sack
> > coalescing, TCP pacing...) all were developed/tested/maintained with
> > GSO/TSO being the norm.
> >
> > Can you please test the following patch ?
>
> Yes, results below:
>
> BBR+fq:
> sg on: 6.02 Gbits/sec
> sg off: 1.33 Gbits/sec
>
> BBR+pfifo_fast:
> sg on: 4.13 Gbits/sec
> sg off: 1.34 Gbits/sec
>
> BBR+fq_codel:
> sg on: 4.16 Gbits/sec
> sg off: 1.35 Gbits/sec
>
> Reno+fq:
> sg on: 6.44 Gbits/sec
> sg off: 1.39 Gbits/sec
>
> Reno+pfifo_fast:
> sg on: 6.36 Gbits/sec
> sg off: 1.39 Gbits/sec
>
> Reno+fq_codel:
> sg on: 6.41 Gbits/sec
> sg off: 1.38 Gbits/sec
>
> While BBR still suffers when fq is not used, disabling sg doesn't bring
> drastic throughput drop anymore. So, looks good to me, eh?
>
Indeed :)
Here are my results on 40Gbit link (mlx4) :
BBR+fq:
sg on: 26 Gbits/sec
sg off: 15.7 Gbits/sec (was 2.3 Gbit before patch)
BBR+pfifo_fast:
sg on: 24.2 Gbits/sec
sg off: 14.9 Gbits/sec (was 0.66 Gbit before patch !!! )
BBR+fq_codel:
sg on: 24.4 Gbits/sec
sg off: 15 Gbits/sec (was 0.66 Gbit before patch !!! )
Reno+fq:
sg on: 20 Gbits/sec
sg off: 15.7 Gbits/sec (was 6 Gbit)
Reno+pfifo_fast:
sg on: 25.7 Gbits/sec
sg off: 15.5 Gbits/sec (was 7 Gbit)
Reno+fq_codel:
sg on: 25.8 Gbits/sec
sg off: 16 Gbits/sec (was 7 Gbit)
Definitely worth it ;)
Thanks !
prev parent reply other threads:[~2018-02-18 22:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 20:42 TCP and BBR: reproducibly low cwnd and bandwidth Oleksandr Natalenko
2018-02-16 15:15 ` Oleksandr Natalenko
2018-02-16 16:25 ` Eric Dumazet
2018-02-16 17:37 ` Oleksandr Natalenko
2018-02-16 16:26 ` Holger Hoffstätte
2018-02-16 16:56 ` Neal Cardwell
2018-02-16 17:13 ` Holger Hoffstätte
2018-02-16 17:35 ` Oleksandr Natalenko
2018-02-16 16:21 ` Eric Dumazet
[not found] ` <CADVnQymiswHBp32dcMvWd1WfYLpFqY4QTas8yABFQE7KKKc5ag@mail.gmail.com>
2018-02-16 16:43 ` Eric Dumazet
2018-02-16 16:45 ` Neal Cardwell
2018-02-16 17:00 ` Oleksandr Natalenko
2018-02-16 17:25 ` Oleksandr Natalenko
2018-02-16 17:56 ` Holger Hoffstätte
2018-02-16 19:54 ` Oleksandr Natalenko
2018-02-16 20:54 ` Eric Dumazet
2018-02-16 22:50 ` Eric Dumazet
2018-02-16 23:06 ` Oleksandr Natalenko
2018-02-16 22:50 ` Oleksandr Natalenko
2018-02-16 22:59 ` Eric Dumazet
2018-02-17 10:01 ` Oleksandr Natalenko
2018-02-17 18:52 ` Eric Dumazet
2018-02-18 21:04 ` Eric Dumazet
2018-02-18 21:06 ` Eric Dumazet
2018-02-18 21:49 ` Oleksandr Natalenko
2018-02-18 22:24 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518992649.55655.19.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).