Netdev List
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: davem@davemloft.net, avagin@virtuozzo.com, pablo@netfilter.org,
	kadlec@blackhole.kfki.hu, fw@strlen.de, yoshfuji@linux-ipv6.org,
	afaerber@suse.de, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, johannes@sipsolutions.net,
	netdev@vger.kernel.org, ktkhai@virtuozzo.com
Subject: [PATCH 04/16] net: Convert icmpv6_sk_ops, ndisc_net_ops and igmp6_net_ops
Date: Mon, 19 Feb 2018 11:48:57 +0300	[thread overview]
Message-ID: <151903013723.32574.14529761208785320979.stgit@localhost.localdomain> (raw)
In-Reply-To: <151902976942.32574.10711323959096437995.stgit@localhost.localdomain>

These pernet_operations create and destroy net::ipv6.icmp_sk
socket, used to send ICMP or error reply.

Nobody can dereference the socket to handle a packet before
net is initialized, as there is no routing; nobody can do
that in parallel with exit, as all of devices are moved
to init_net or destroyed and there are no packets it-flight.
So, it's possible to mark these pernet_operations as async.

The same for ndisc_net_ops and for igmp6_net_ops. The last
one also creates and destroys /proc entries.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
 net/ipv6/icmp.c  |    1 +
 net/ipv6/mcast.c |    1 +
 net/ipv6/ndisc.c |    1 +
 3 files changed, 3 insertions(+)

diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index 6ae5dd3f4d0d..4fa4f1b150a4 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -997,6 +997,7 @@ static void __net_exit icmpv6_sk_exit(struct net *net)
 static struct pernet_operations icmpv6_sk_ops = {
 	.init = icmpv6_sk_init,
 	.exit = icmpv6_sk_exit,
+	.async = true,
 };
 
 int __init icmpv6_init(void)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 9b9d2ff01b35..d9bb933dd5c4 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -2997,6 +2997,7 @@ static void __net_exit igmp6_net_exit(struct net *net)
 static struct pernet_operations igmp6_net_ops = {
 	.init = igmp6_net_init,
 	.exit = igmp6_net_exit,
+	.async = true,
 };
 
 int __init igmp6_init(void)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index f61a5b613b52..0a19ce3a6f7f 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1882,6 +1882,7 @@ static void __net_exit ndisc_net_exit(struct net *net)
 static struct pernet_operations ndisc_net_ops = {
 	.init = ndisc_net_init,
 	.exit = ndisc_net_exit,
+	.async = true,
 };
 
 int __init ndisc_init(void)

  parent reply	other threads:[~2018-02-19  8:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  8:47 [PATCH 00/16] Converting pernet_operations (part #2) Kirill Tkhai
2018-02-19  8:48 ` [PATCH 01/16] net: Convert inet6_net_ops Kirill Tkhai
2018-02-19  8:48 ` [PATCH 02/16] net: Convert cfg80211_pernet_ops Kirill Tkhai
2018-02-19  8:48 ` [PATCH 03/16] net: Convert ip6mr_net_ops Kirill Tkhai
2018-02-19  8:48 ` Kirill Tkhai [this message]
2018-02-19  8:49 ` [PATCH 05/16] net: Convert raw6_net_ops, udplite6_net_ops, ipv6_proc_ops, if6_proc_net_ops and ip6_route_net_late_ops Kirill Tkhai
2018-02-19  8:49 ` [PATCH 06/16] net: Convert ipv6_inetpeer_ops Kirill Tkhai
2018-02-19  8:49 ` [PATCH 07/16] net: Convert fib6_rules_net_ops Kirill Tkhai
2018-02-19  8:49 ` [PATCH 08/16] net: Convert tcpv6_net_ops Kirill Tkhai
2018-02-19  8:49 ` [PATCH 09/16] net: Convert ipv6_sysctl_net_ops Kirill Tkhai
2018-02-19  8:49 ` [PATCH 10/16] net: Convert ping_v6_net_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 11/16] net: Convert ip6_flowlabel_net_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 12/16] net: Convert xfrm6_net_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 13/16] net: Convert fib6_net_ops, ipv6_addr_label_ops and ip6_segments_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 14/16] net: Convert ip6_frags_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 15/16] net: Convert ip_tables_net_ops, udplite6_net_ops and xt_net_ops Kirill Tkhai
2018-02-19  8:50 ` [PATCH 16/16] net: Convert iptable_filter_net_ops Kirill Tkhai
2018-02-19 13:51 ` [PATCH 00/16] Converting pernet_operations (part #2) Kirill Tkhai
2018-02-19 19:22 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151903013723.32574.14529761208785320979.stgit@localhost.localdomain \
    --to=ktkhai@virtuozzo.com \
    --cc=afaerber@suse.de \
    --cc=avagin@virtuozzo.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=johannes@sipsolutions.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=steffen.klassert@secunet.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox