From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1519192048.55655.35.camel@gmail.com> Subject: Re: [PATCH] netlink: put module reference if dump start fails From: Eric Dumazet To: "Jason A. Donenfeld" , davem@davemloft.net, johannes.berg@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 20 Feb 2018 21:47:28 -0800 In-Reply-To: <20180221034159.14685-1-Jason@zx2c4.com> References: <20180221034159.14685-1-Jason@zx2c4.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, 2018-02-21 at 04:41 +0100, Jason A. Donenfeld wrote: > Before, if cb->start() failed, the module reference would never be put, > because cb->cb_running is intentionally false at this point. Users are > generally annoyed by this because they can no longer unload modules that > leak references. Also, it may be possible to tediously wrap a reference > counter back to zero, especially since module.c still uses atomic_inc > instead of refcount_inc. > > This patch expands the error path to simply call module_put if > cb->start() fails. > > Signed-off-by: Jason A. Donenfeld > --- > This probably should be queued up for stable. When was the bug added ? This would help a lot stable teams ... Thanks.