From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48756 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752690AbeBUPzM (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 21 Feb 2018 10:55:12 -0500
Message-ID: <1519228509.2988.17.camel@redhat.com>
Subject: Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
        Oleksandr Natalenko <oleksandr@natalenko.name>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Neal Cardwell <ncardwell@google.com>
Date: Wed, 21 Feb 2018 16:55:09 +0100
In-Reply-To: <CANn89iKpnHOWda1Lxj77eJYYQ7N-iZki_RQOkks7VVWyh-98Xw@mail.gmail.com>
References: <20180219195652.242663-1-edumazet@google.com>
         <CANn89iK1tTWqXmYZq67drQrJAwxA3UvKscbCpeJhB1hm-k5gmQ@mail.gmail.com>
         <1519157377.55655.26.camel@gmail.com> <2638137.lzCXOlOYsz@natalenko.name>
         <1519168897.55655.31.camel@gmail.com> <1519224183.55655.40.camel@gmail.com>
         <1519225272.2988.14.camel@redhat.com>
         <CANn89iKpnHOWda1Lxj77eJYYQ7N-iZki_RQOkks7VVWyh-98Xw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2018-02-21 at 07:09 -0800, Eric Dumazet wrote:
> On Wed, Feb 21, 2018 at 7:01 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> > 
> > Very minor nit, why don't:
> > 
> >         return max_t(u32, bytes / mss_now, min_tso_segs);
> > 
> > and drop the 'segs' local variable?
> 
> Simply to ease backports.
> 
> We had some constant changes in this function in the past.

Ok, thank you for the explanation. No objections on my side.

Cheers,

Paolo