From: Eric Dumazet <eric.dumazet@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning
Date: Thu, 22 Feb 2018 08:40:25 -0800 [thread overview]
Message-ID: <1519317625.55655.58.camel@gmail.com> (raw)
In-Reply-To: <20180222155546.1747665-1-arnd@arndb.de>
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote:
...
>
> This code is old, so Cc stable to make sure that we don't get the warning
> for older kernels built with new gcc.
>
> Cc: stable@vger.kernel.org
This part makes little sense to me for two reasons.
1) David Miller handles stable submission himself
( Documentation/networking/netdev-FAQ.txt )
2) We are not supposed to make sure old kernels will compile with
future compilers.
That would need a lot of work and potential new bugs, not worth the
time.
Otherwise your patch looks fine really ;)
next prev parent reply other threads:[~2018-02-22 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 15:55 [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning Arnd Bergmann
2018-02-22 16:40 ` Eric Dumazet [this message]
2018-02-22 16:56 ` Arnd Bergmann
2018-02-23 16:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519317625.55655.58.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).