From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:39044 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbeBWLMz (ORCPT ); Fri, 23 Feb 2018 06:12:55 -0500 Received: by mail-wm0-f65.google.com with SMTP id 191so3892353wmm.4 for ; Fri, 23 Feb 2018 03:12:54 -0800 (PST) From: Eyal Birger To: netdev@vger.kernel.org Cc: dsahern@gmail.com, shmulik@metanetworks.com, Eyal Birger Subject: [PATCH iproute2-next 1/2] tc: ematch: add parse_eopt_argv() method for providing ematches with argv parameters Date: Fri, 23 Feb 2018 13:12:24 +0200 Message-Id: <1519384345-17115-2-git-send-email-eyal.birger@gmail.com> In-Reply-To: <1519384345-17115-1-git-send-email-eyal.birger@gmail.com> References: <1519384345-17115-1-git-send-email-eyal.birger@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: ematche uses YACC to parse ematch arguments and places them in struct bstr linked lists. It is useful to be able to receive parameters as argc,argv in order to use getopt (and alike) argument parsers. Signed-off-by: Eyal Birger --- tc/m_ematch.c | 27 ++++++++++++++++++++++++++- tc/m_ematch.h | 2 ++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/tc/m_ematch.c b/tc/m_ematch.c index 7dbc2e7..61f8fb3 100644 --- a/tc/m_ematch.c +++ b/tc/m_ematch.c @@ -169,6 +169,31 @@ static struct ematch_util *get_ematch_kind_num(__u16 kind) return get_ematch_kind(name); } +static int em_parse_call(struct nlmsghdr *n, struct tcf_ematch_hdr *hdr, + struct ematch_util *e, struct ematch *t) +{ + if (e->parse_eopt_argv) { + int argc = 0, i = 0, ret; + struct bstr *args; + char **argv; + + for (args = t->args; args; args = bstr_next(args)) + argc++; + argv = calloc(argc, sizeof(char *)); + if (!argv) + return -1; + for (args = t->args; args; args = bstr_next(args)) + argv[i++] = args->data; + + ret = e->parse_eopt_argv(n, hdr, argc, argv); + + free(argv); + return ret; + } + + return e->parse_eopt(n, hdr, t->args->next); +} + static int parse_tree(struct nlmsghdr *n, struct ematch *tree) { int index = 1; @@ -212,7 +237,7 @@ static int parse_tree(struct nlmsghdr *n, struct ematch *tree) } hdr.kind = num; - if (e->parse_eopt(n, &hdr, t->args->next) < 0) + if (em_parse_call(n, &hdr, e, t) < 0) return -1; } diff --git a/tc/m_ematch.h b/tc/m_ematch.h index fa6e214..f634f19 100644 --- a/tc/m_ematch.h +++ b/tc/m_ematch.h @@ -88,6 +88,8 @@ struct ematch_util int kind_num; int (*parse_eopt)(struct nlmsghdr *,struct tcf_ematch_hdr *, struct bstr *); + int (*parse_eopt_argv)(struct nlmsghdr *, struct tcf_ematch_hdr *, + int, char **); int (*print_eopt)(FILE *, struct tcf_ematch_hdr *, void *, int); void (*print_usage)(FILE *); struct ematch_util *next; -- 2.7.4