From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Mendoza-Jonas Subject: Re: [PATCH net-next] net/ncsi: Add generic netlink family Date: Tue, 27 Feb 2018 13:29:41 +1100 Message-ID: <1519698581.7888.2.camel@mendozajonas.com> References: <20180223041518.20195-1-sam@mendozajonas.com> <20180226.113136.1568195044048732904.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org To: David Miller Return-path: In-Reply-To: <20180226.113136.1568195044048732904.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 23 Feb 2018 15:15:18 +1100 > > > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination. > > + * Requires NCSI_ATTR_IFINDEX and the preferred NCSI_ATTR_PACKAGE_ID and > > + * optionally the preferred NCSI_ATTR_CHANNEL_ID. If neither IDs are > > + * specified the setting is cleared. > > I think clearing the setting when the required attributes are missing > is dangerous behavior. > > It is ambiguous whether the user intended the setting to be cleared, > or was in error and forgot to supply the attribute due to a bug. Fair point - I'll change this to be an error and add a separate command to clear the setting explicitly. In that vein is having NCSI_ATTR_CHANNEL_ID as an optional parameter ambiguous enough to justify a separate command as well? Regards, Sam