From: Oliver Neukum <oneukum@suse.com>
To: "Bjørn Mork" <bjorn@mork.no>,
"Bassem Boubaker" <bassem.boubaker@actia.fr>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN
Date: Tue, 27 Feb 2018 13:43:26 +0100 [thread overview]
Message-ID: <1519735406.18525.9.camel@suse.com> (raw)
In-Reply-To: <878tbebopw.fsf@miraculix.mork.no>
Am Dienstag, den 27.02.2018, 13:29 +0100 schrieb Bjørn Mork :
> Bassem Boubaker <bassem.boubaker@actia.fr> writes:
>
> >
> > +#define GEMALTO_VENDOR_ID 0x1e2d
>
> This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c.
>
> I have no idea which defintion is most correct, but I believe the macros
> should be kept identical whatever you decide. Anything else is just
> unnecessarily confusing.
>
> IMHO the company name tracking macros have grown beyond useful a long
> time ago. They just make it harder to grep for the IDs without adding
> any useful information whatsoever. And because you have cases like this
> where the same number end up having different names, they sometimes hide
> information which a plain number would have revealed.
Hi,
I concur. Could you redo the patch and just use a plain number?
Regards
Oliver
next prev parent reply other threads:[~2018-02-27 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 11:49 [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN Bassem Boubaker
2018-02-27 12:29 ` Bjørn Mork
2018-02-27 12:43 ` Oliver Neukum [this message]
2018-02-27 13:04 ` Bassem Boubaker
2018-02-27 13:11 ` Oliver Neukum
2018-02-27 19:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519735406.18525.9.camel@suse.com \
--to=oneukum@suse.com \
--cc=bassem.boubaker@actia.fr \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).