From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Benjamin Poirier <bpoirier@suse.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000e: Fix link status in case of error.
Date: Wed, 28 Feb 2018 09:16:42 -0800 [thread overview]
Message-ID: <1519838202.7902.2.camel@intel.com> (raw)
In-Reply-To: <20180228052006.12074-1-bpoirier@suse.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Wed, 2018-02-28 at 14:20 +0900, Benjamin Poirier wrote:
> Before commit 19110cfbb34d ("e1000e: Separate signaling for link
> check/link
> up"), errors which happen after "get_link_status = false" in the
> copper
> check_for_link callbacks would be ignored and the link considered up.
> After
> that commit, any error implies that the link is down. Since all
> combinations of link up/down and error/no error are possible, do the
> same
> thing as e1000e_phy_has_link_generic() and return the link status in
> a
> separate variable.
>
> Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link
> up")
> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
A minor nitpick, almost every patch you send out, has your patch
title/subject ending in a period which is not needed or wanted. Patch
titles/subjects should not be complete sentences, so they do not need
punctuation at the end.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-28 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 5:20 [PATCH] e1000e: Fix link status in case of error Benjamin Poirier
2018-02-28 16:48 ` Alexander Duyck
2018-03-01 6:40 ` Benjamin Poirier
2018-03-01 19:07 ` Alexander Duyck
2018-02-28 17:16 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519838202.7902.2.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=bpoirier@suse.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).