From: Yuval Mintz <yuvalm@mellanox.com>
To: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, davem@damveloft.net
Cc: mlxsw@mellanox.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, Yuval Mintz <yuvalm@mellanox.com>
Subject: [PATCH v2 net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags
Date: Wed, 28 Feb 2018 23:29:38 +0200 [thread overview]
Message-ID: <1519853379-1969-11-git-send-email-yuvalm@mellanox.com> (raw)
In-Reply-To: <1519853379-1969-1-git-send-email-yuvalm@mellanox.com>
MFC_NOTIFY exists in ip6mr, probably as some legacy code
[was already removed for ipmr in commit
06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags enum").
Remove it from ip6mr as well, and move the enum into a common file;
Notice MFC_OFFLOAD is currently only used by ipmr.
Signed-off-by: Yuval Mintz <yuvalm@mellanox.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
include/linux/mroute.h | 9 ---------
include/linux/mroute6.h | 3 ---
include/linux/mroute_base.h | 9 +++++++++
net/ipv6/ip6mr.c | 3 ---
4 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/include/linux/mroute.h b/include/linux/mroute.h
index 63b36e6..7ed82e4 100644
--- a/include/linux/mroute.h
+++ b/include/linux/mroute.h
@@ -65,15 +65,6 @@ struct vif_entry_notifier_info {
#define VIFF_STATIC 0x8000
-/* mfc_flags:
- * MFC_STATIC - the entry was added statically (not by a routing daemon)
- * MFC_OFFLOAD - the entry was offloaded to the hardware
- */
-enum {
- MFC_STATIC = BIT(0),
- MFC_OFFLOAD = BIT(1),
-};
-
struct mfc_cache_cmp_arg {
__be32 mfc_mcastgrp;
__be32 mfc_origin;
diff --git a/include/linux/mroute6.h b/include/linux/mroute6.h
index 6acf576..1ac38e6 100644
--- a/include/linux/mroute6.h
+++ b/include/linux/mroute6.h
@@ -81,9 +81,6 @@ struct mfc6_cache {
};
};
-#define MFC_STATIC 1
-#define MFC_NOTIFY 2
-
#define MFC_ASSERT_THRESH (3*HZ) /* Maximal freq. of asserts */
struct rtmsg;
diff --git a/include/linux/mroute_base.h b/include/linux/mroute_base.h
index cfaec9b..f40202b 100644
--- a/include/linux/mroute_base.h
+++ b/include/linux/mroute_base.h
@@ -45,6 +45,15 @@ struct vif_device {
#define VIF_EXISTS(_mrt, _idx) (!!((_mrt)->vif_table[_idx].dev))
+/* mfc_flags:
+ * MFC_STATIC - the entry was added statically (not by a routing daemon)
+ * MFC_OFFLOAD - the entry was offloaded to the hardware
+ */
+enum {
+ MFC_STATIC = BIT(0),
+ MFC_OFFLOAD = BIT(1),
+};
+
/**
* struct mr_mfc - common multicast routing entries
* @mnode: rhashtable list
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index ddd9e6b..c3b3f1c 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/ip6mr.c
@@ -2203,9 +2203,6 @@ int ip6mr_get_route(struct net *net, struct sk_buff *skb, struct rtmsg *rtm,
return err;
}
- if (rtm->rtm_flags & RTM_F_NOTIFY)
- cache->_c.mfc_flags |= MFC_NOTIFY;
-
err = __ip6mr_fill_mroute(mrt, skb, cache, rtm);
read_unlock(&mrt_lock);
return err;
--
2.4.3
next prev parent reply other threads:[~2018-02-28 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 21:29 [PATCH v2 net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6 Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 01/11] ipmr,ipmr6: Define a uniform vif_device Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 02/11] ip6mr: Make mroute_sk rcu-based Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 03/11] ip6mr: Align hash implementation to ipmr Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 04/11] mroute*: Make mr_table a common struct Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure Yuval Mintz
2018-02-28 21:58 ` Nikolay Aleksandrov
2018-02-28 21:29 ` [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache Yuval Mintz
2018-02-28 21:56 ` Nikolay Aleksandrov
2018-02-28 21:29 ` [PATCH v2 net-next 08/11] ipmr, ip6mr: Unite mfc seq logic Yuval Mintz
2018-02-28 21:29 ` [PATCH v2 net-next 09/11] ipmr, ip6mr: Unite vif seq functions Yuval Mintz
2018-02-28 21:29 ` Yuval Mintz [this message]
2018-02-28 21:29 ` [PATCH v2 net-next 11/11] ipmr, ip6mr: Unite dumproute flows Yuval Mintz
2018-03-01 18:20 ` [PATCH v2 net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519853379-1969-11-git-send-email-yuvalm@mellanox.com \
--to=yuvalm@mellanox.com \
--cc=davem@damveloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).