* [PATCH v3] net: iucv: Free memory obtained by kzalloc
@ 2018-03-01 11:31 Arvind Yadav
2018-03-01 12:50 ` Cornelia Huck
2018-03-01 16:18 ` Ursula Braun
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2018-03-01 11:31 UTC (permalink / raw)
To: jwi, ubraun, davem; +Cc: linux-kernel, linux-s390, netdev
Free memory by calling put_device(), if afiucv_iucv_init is not
successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2:
Calling put_device() before kfree().
changes in v3:
No need to call kfree(). So removed kfree().
net/iucv/af_iucv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 1e8cc7b..9e2643a 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void)
af_iucv_dev->driver = &af_iucv_driver;
err = device_register(af_iucv_dev);
if (err)
- goto out_driver;
+ goto out_iucv_dev;
return 0;
+out_iucv_dev:
+ put_device(af_iucv_dev);
out_driver:
driver_unregister(&af_iucv_driver);
out_iucv:
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc
2018-03-01 11:31 [PATCH v3] net: iucv: Free memory obtained by kzalloc Arvind Yadav
@ 2018-03-01 12:50 ` Cornelia Huck
2018-03-01 16:18 ` Ursula Braun
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2018-03-01 12:50 UTC (permalink / raw)
To: Arvind Yadav; +Cc: jwi, ubraun, davem, linux-kernel, linux-s390, netdev
On Thu, 1 Mar 2018 17:01:57 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> Free memory by calling put_device(), if afiucv_iucv_init is not
> successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Calling put_device() before kfree().
> changes in v3:
> No need to call kfree(). So removed kfree().
>
> net/iucv/af_iucv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
> index 1e8cc7b..9e2643a 100644
> --- a/net/iucv/af_iucv.c
> +++ b/net/iucv/af_iucv.c
> @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void)
> af_iucv_dev->driver = &af_iucv_driver;
> err = device_register(af_iucv_dev);
> if (err)
> - goto out_driver;
> + goto out_iucv_dev;
> return 0;
>
> +out_iucv_dev:
> + put_device(af_iucv_dev);
> out_driver:
> driver_unregister(&af_iucv_driver);
> out_iucv:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc
2018-03-01 11:31 [PATCH v3] net: iucv: Free memory obtained by kzalloc Arvind Yadav
2018-03-01 12:50 ` Cornelia Huck
@ 2018-03-01 16:18 ` Ursula Braun
1 sibling, 0 replies; 3+ messages in thread
From: Ursula Braun @ 2018-03-01 16:18 UTC (permalink / raw)
To: Arvind Yadav; +Cc: jwi, davem, linux-kernel, linux-s390, netdev
On 03/01/2018 12:31 PM, Arvind Yadav wrote:
> Free memory by calling put_device(), if afiucv_iucv_init is not
> successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Calling put_device() before kfree().
> changes in v3:
> No need to call kfree(). So removed kfree().
>
> net/iucv/af_iucv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
> index 1e8cc7b..9e2643a 100644
> --- a/net/iucv/af_iucv.c
> +++ b/net/iucv/af_iucv.c
> @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void)
> af_iucv_dev->driver = &af_iucv_driver;
> err = device_register(af_iucv_dev);
> if (err)
> - goto out_driver;
> + goto out_iucv_dev;
> return 0;
>
> +out_iucv_dev:
> + put_device(af_iucv_dev);
> out_driver:
> driver_unregister(&af_iucv_driver);
> out_iucv:
>
Thanks Arvind, I have added this patch version to our local repository; it will be part of a
coming patch submission to Dave Miller.
Regards, Ursula
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-01 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 11:31 [PATCH v3] net: iucv: Free memory obtained by kzalloc Arvind Yadav
2018-03-01 12:50 ` Cornelia Huck
2018-03-01 16:18 ` Ursula Braun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).