From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f67.google.com ([209.85.214.67]:36292 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034007AbeCASpz (ORCPT ); Thu, 1 Mar 2018 13:45:55 -0500 Received: by mail-it0-f67.google.com with SMTP id u5so9049200itc.1 for ; Thu, 01 Mar 2018 10:45:55 -0800 (PST) From: Roman Mashak To: davem@davemloft.net Cc: netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us, xiyou.wangcong@gmail.com, Roman Mashak Subject: [PATCH 2/5] net sched actions: add new tc_action_ops callback Date: Thu, 1 Mar 2018 13:45:28 -0500 Message-Id: <1519929931-1119-3-git-send-email-mrv@mojatatu.com> In-Reply-To: <1519929931-1119-1-git-send-email-mrv@mojatatu.com> References: <1519929931-1119-1-git-send-email-mrv@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: Add a new callback in tc_action_ops, it will be needed by the tc actions to compute its size when a ADD/DELETE notification message is constructed. This routine has to take into account optional/variable size TLVs specific per action. Signed-off-by: Roman Mashak --- include/net/act_api.h | 1 + net/sched/act_api.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/include/net/act_api.h b/include/net/act_api.h index 9c2f226..0a56465 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h @@ -97,6 +97,7 @@ struct tc_action_ops { const struct tc_action_ops *, struct netlink_ext_ack *); void (*stats_update)(struct tc_action *, u64, u32, u64); + size_t (*get_fill_size)(const struct tc_action *act); struct net_device *(*get_dev)(const struct tc_action *a); }; diff --git a/net/sched/act_api.c b/net/sched/act_api.c index acac92a..6f3307f 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -136,6 +136,14 @@ static size_t tcf_action_full_attrs_size(size_t sz) + sz; } +static size_t tcf_action_fill_size(const struct tc_action *act) +{ + if (act->ops->get_fill_size) + return act->ops->get_fill_size(act) + + tcf_action_shared_attrs_size(act); + return 0; +} + static int tcf_dump_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb, struct netlink_callback *cb) { -- 2.7.4